Page MenuHomeFreeBSD

iflib: Make if_shared_ctx_t a pointer to const
ClosedPublic

Authored by markj on Mar 5 2021, 9:10 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Oct 18, 8:28 PM
Unknown Object (File)
Tue, Oct 13, 11:17 AM
Unknown Object (File)
Sun, Oct 11, 7:14 PM
Unknown Object (File)
Sun, Oct 11, 7:05 PM
Unknown Object (File)
Sat, Oct 3, 4:04 PM
Unknown Object (File)
Tue, Sep 22, 11:09 PM
Unknown Object (File)
Sun, Sep 20, 8:18 AM
Unknown Object (File)
Sep 12 2026, 9:36 AM
Subscribers

Details

Summary

This structure is shared among multiple instances of a driver, so we
should ensure that it doesn't somehow get treated as if there's a
separate instance per interface. This is especially important for
software-only drivers like wg.

We could perhaps make DEVICE_REGISTER return a pointer to const as well,
so the sctx structures themselves could be defined as const. I don't
quite understand what this method is supposed to do in the general case
though, so I didn't modify it.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 37628
Build 34517: arc lint + arc unit

Event Timeline

markj requested review of this revision.Mar 5 2021, 9:10 PM
sys/net/iflib.h
52

This is the meat of the change, the rest is required to compile after.

This revision is now accepted and ready to land.Mar 5 2021, 10:15 PM
This revision was automatically updated to reflect the committed changes.