Page MenuHomeFreeBSD

iflib: Make if_shared_ctx_t a pointer to const
ClosedPublic

Authored by markj on Mar 5 2021, 9:10 PM.
Tags
None
Referenced Files
F80164916: D29102.id85244.diff
Thu, Mar 28, 7:07 PM
Unknown Object (File)
Feb 15 2024, 12:50 AM
Unknown Object (File)
Feb 5 2024, 10:15 AM
Unknown Object (File)
Jan 17 2024, 4:29 PM
Unknown Object (File)
Jan 13 2024, 2:20 PM
Unknown Object (File)
Dec 20 2023, 12:34 PM
Unknown Object (File)
Oct 20 2023, 9:58 PM
Unknown Object (File)
Oct 4 2023, 1:58 AM
Subscribers

Details

Summary

This structure is shared among multiple instances of a driver, so we
should ensure that it doesn't somehow get treated as if there's a
separate instance per interface. This is especially important for
software-only drivers like wg.

We could perhaps make DEVICE_REGISTER return a pointer to const as well,
so the sctx structures themselves could be defined as const. I don't
quite understand what this method is supposed to do in the general case
though, so I didn't modify it.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj requested review of this revision.Mar 5 2021, 9:10 PM
sys/net/iflib.h
52

This is the meat of the change, the rest is required to compile after.

This revision is now accepted and ready to land.Mar 5 2021, 10:15 PM
This revision was automatically updated to reflect the committed changes.