Differential D28748

ig4(4): Use calculated value when sda_hold is zero in ACPI
Needs ReviewPublic
Actions

Authored by allanjude on Feb 17 2021, 9:35 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Mar 16, 11:40 PM

	Unknown Object (File)
	Fri, Mar 14, 7:29 PM

	Unknown Object (File)
	Fri, Mar 14, 6:31 PM

	Unknown Object (File)
	Fri, Mar 14, 3:10 PM

	Unknown Object (File)
	Thu, Mar 13, 2:40 AM

	Unknown Object (File)
	Wed, Mar 5, 6:05 AM

	Unknown Object (File)
	Feb 16 2025, 12:53 AM

	Unknown Object (File)
	Jan 27 2025, 9:12 AM

View All 58 Files

Subscribers

Details

Reviewers

Summary

Sponsored by: Ampere Computing LLC

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 37123
Build 34012: arc lint + arc unit

Event Timeline

allanjude created this revision.Feb 17 2021, 9:35 PM

Herald added a subscriber: imp. · View Herald TranscriptFeb 17 2021, 9:35 PM

allanjude requested review of this revision.Feb 17 2021, 9:35 PM

Harbormaster completed remote builds in B37123: Diff 84143.Feb 17 2021, 9:35 PM

allanjude added a parent revision: D28747: ig4(4): Increase timeout to about 1 second.Feb 17 2021, 9:35 PM

allanjude added a child revision: D28749: ipmi_ssif: Fix inverted for the end of multi-part reads.

allanjude mentioned this in D28707: Fix attachment of IPMI driver on ARM64.Feb 17 2021, 9:38 PM

Is there any docs on what the acpi objects should contain ?

allanjude added a reviewer: scottph.Feb 18 2021, 3:53 PM

So this isn't needed for what I'm doing... it looks interesting. What's the status?

Revision Contents
Changeset List

Path

Size

sys/

dev/

ichiic/

8 lines

Diff 84143

sys/dev/ichiic/ig4_iic.c

	Show First 20 Lines • Show All 798 Lines • ▼ Show 20 Lines		if (ACPI_FAILURE(status))
	return (status);			return (status);

	status = AE_TYPE;			status = AE_TYPE;
	obj = (ACPI_OBJECT *)buf.Pointer;			obj = (ACPI_OBJECT *)buf.Pointer;
	if (obj->Type == ACPI_TYPE_PACKAGE && obj->Package.Count == 3) {			if (obj->Type == ACPI_TYPE_PACKAGE && obj->Package.Count == 3) {
	elems = obj->Package.Elements;			elems = obj->Package.Elements;
	*scl_hcnt = elems[0].Integer.Value & IG4_SCL_CLOCK_MASK;			*scl_hcnt = elems[0].Integer.Value & IG4_SCL_CLOCK_MASK;
	*scl_lcnt = elems[1].Integer.Value & IG4_SCL_CLOCK_MASK;			*scl_lcnt = elems[1].Integer.Value & IG4_SCL_CLOCK_MASK;
				if (elems[2].Integer.Value != 0) {
				/*
				* If the value in the table is zero, stick
				* with value calculated earlier for sda_hold.
				*/
	*sda_hold = elems[2].Integer.Value & IG4_SDA_TX_HOLD_MASK;			*sda_hold = elems[2].Integer.Value & IG4_SDA_TX_HOLD_MASK;
				}
	status = AE_OK;			status = AE_OK;
	}			}

	AcpiOsFree(obj);			AcpiOsFree(obj);

	return (status);			return (status);
	}			}
	#endif /* DEV_ACPI */			#endif /* DEV_ACPI */
	▲ Show 20 Lines • Show All 403 Lines • Show Last 20 Lines