Differential D12017

10 - compatible USB HID multi-touch devices
ClosedPublic
Actions

Authored by wulf on Aug 13 2017, 10:35 PM.

Details

Reviewers

gonzo
• hselasky
bcr

Group Reviewers

manpages

Commits

rS324769: MFC r322695:
rS322695: Add support for generic MS Windows 7/8/10-compatible USB HID touchscreens

Summary

Add support for generic MS Windows 7/8/10 - compatible USB HID multi-touch touchscreens via evdev protocol.
Intended to be a native replacement of hid-miltitouch.c driver found in Linux distributions and multimedia/webcamd port.

To compile this driver into the kernel, place the following lines into your kernel configuration file:

device wmt
device usb
device evdev

Alternatively, to load the driver as a module at boot time, place the following line in loader.conf(5):

wmt_load="YES"

To get multi-touch device working in X, one should install ports/x11-drivers/xf86-input-evdev and properly configure it.

Currently, driver does not support pens or touchpads.

Note: wmt.ko should be kld-loaded before uhid driver to take precedence over it! Otherwise uhid can be kld-unloaded after loading of wmt.

Test Plan

Tested with ELAN (0x04f3:0x0012) and VirtualBox touchscreens

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

wulf created this revision.Aug 13 2017, 10:35 PM

Herald added a reviewer: manpages. · View Herald TranscriptAug 13 2017, 10:35 PM

Herald added a subscriber: imp. · View Herald Transcript

CFT has been announced on current@

OK from manpages, but you need to bump the .Dd to the date when you commit this. Thanks!

This revision is now accepted and ready to land.Aug 14 2017, 7:03 AM

• hselasky accepted this revision.Aug 14 2017, 12:14 PM

• hselasky added inline comments.

sys/dev/usb/input/wmt.c
516	One variable per line.
519	extra spacing here before report_id;
sys/dev/usb/usb_hid.c
862	Try to write like this: scale[16][2] = { .... [0] = { ... }, [1] = { ... }, [2] = { ... },
sys/modules/usb/wmt/Makefile
3	Should you use ${SRCTOP} here ? Check other Makefiles in sys/modules/usb .