mbuf: remove remnants of caddr_t
AcceptedPublic
Actions

Authored by glebius on Wed, Oct 14, 7:46 PM.

Details

Reviewers

adrian
tuexen
zlei

Group Reviewers

network
transport

Summary

caddr_t is a typedef for a character pointer (char *) that originated in
Version 7 Unix, released by AT&T in 1979. It became obsolete in 1981,
when ANSI C introduced void *.

There is a lot of code that uses m->m_data for arithmetics, thus we can't
switch it to void * easily. Let's at least stop proliferation of caddr_t.
We have developers that are twice younger than obsoletion of this type.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 78232
Build 75115: arc lint + arc unit

Event Timeline

glebius created this revision.Wed, Oct 14, 7:46 PM

Herald added a subscriber: imp. · View Herald TranscriptWed, Oct 14, 7:46 PM

glebius requested review of this revision.Wed, Oct 14, 7:46 PM

Harbormaster completed remote builds in B78225: Diff 189931.Wed, Oct 14, 7:46 PM

adrian accepted this revision as: adrian.Wed, Oct 14, 7:48 PM

This revision is now accepted and ready to land.Wed, Oct 14, 7:48 PM

tuexen accepted this revision.Wed, Oct 14, 7:49 PM

Sorry, dropped unfinished diff. Will update.

Change m_append, m_copyback, m_copydata prototypes to use void *.

This revision now requires review to proceed.Wed, Oct 14, 9:06 PM

Herald added a subscriber: olce. · View Herald TranscriptWed, Oct 14, 9:06 PM

Harbormaster completed remote builds in B78227: Diff 189937.Wed, Oct 14, 9:06 PM

We have developers that are twice younger than obsoletion of this type.

Looks like I'm not qualified to approve this one. 🚶

adrian accepted this revision as: adrian.Wed, Oct 14, 11:24 PM

This revision is now accepted and ready to land.Wed, Oct 14, 11:24 PM

zlei added a subscriber: zlei.Thu, Oct 15, 3:13 AM

zlei added inline comments.

sys/kern/uipc_mbuf.c
699	Maybe it is shorter to use macro `mtodo` ?
1296	Actually `bzero()` does not care about the type. No need to cast to `char *`.
1311	Ditto.
1356
1356
1369
sys/sys/mbuf.h
347	I guess the type of `m_data` can eventually be converted `void *` ? But many drivers access `m_data` directly.

adrian added inline comments.Thu, Oct 15, 3:18 AM

sys/sys/mbuf.h
347	I'd be all for a pass through all direct references of m_data and turning them into mtod / mtodo calls. (And maybe at the same time make an mtod_const ...)