Differential D59779

bhyve: usb: add a finer-grained mutex for the event thread
AcceptedPublic
Actions

Authored by kevans on Fri, Sep 18, 1:58 AM.

Tags

None

Referenced Files

	F175520200: D59779.diff
	Sun, Oct 11, 10:18 AM

	Unknown Object (File)
	Sat, Oct 10, 6:24 AM

	Unknown Object (File)
	Sat, Oct 10, 5:41 AM

	Unknown Object (File)
	Sat, Oct 10, 5:41 AM

	Unknown Object (File)
	Sat, Oct 10, 3:21 AM

	Unknown Object (File)
	Fri, Oct 9, 9:54 PM

	Unknown Object (File)
	Fri, Oct 9, 8:53 PM

	Unknown Object (File)
	Fri, Oct 9, 5:22 PM

View All 46 Files

Subscribers

Details

Reviewers

markj
bnovkov
aokblast

Group Reviewers

Summary

Nothing today will serialize er_enq_idx / er_events_cnt updates against
the ERDP handler recalculations. This isn't strictly a problem until
we add support for a USB passthru device (which adds another thread for
handling libusb events), but pushing it in advance makes the meatier
bits of passthru more reviewable.

Sponsored by: The FreeBSD Foundation (aokblast)

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 77045
Build 73928: arc lint + arc unit

Event Timeline

kevans created this revision.Fri, Sep 18, 1:58 AM

Herald added subscribers: bcran, rgrimes, imp. · View Herald TranscriptFri, Sep 18, 1:58 AM

kevans requested review of this revision.Fri, Sep 18, 1:58 AM

Harbormaster completed remote builds in B77045: Diff 187018.Fri, Sep 18, 1:58 AM

kevans added a child revision: D59780: bhyve: usb: fix XHCI_STREAMS_MAX and stream handling.Fri, Sep 18, 1:58 AM

kevans mentioned this in D52166: bhyve: implement single USB device passthrough support.Fri, Sep 18, 2:02 AM

emaste added a subscriber: emaste.Fri, Sep 18, 6:43 PM

Seems ok, but pci_xhci_reset() resets the event fields as well. Is there a reason not to use this mutex to synchronize with those events too?

usr.sbin/bhyve/pci_xhci.c
2182	The high bits case above does touch those fields though.

Extend locking to ERSTBA handling and pci_xhci_reset()

Harbormaster completed remote builds in B77069: Diff 187144.Fri, Sep 18, 8:25 PM

markj accepted this revision as: markj.Fri, Sep 18, 8:39 PM

This revision is now accepted and ready to land.Fri, Sep 18, 8:39 PM

bnovkov accepted this revision as: bnovkov.Sat, Sep 19, 10:18 AM

bnovkov added a subscriber: bnovkov.

bnovkov added inline comments.

usr.sbin/bhyve/pci_xhci.c
268–276	Small nit.

aokblast accepted this revision.Sat, Sep 26, 6:47 AM

kevans mentioned this in D60432: bhyve: xhci: serialise the device callbacks without the controller lock.Wed, Oct 7, 12:06 PM

wanpengqian_gmail.com added a child revision: D60432: bhyve: xhci: serialise the device callbacks without the controller lock.Wed, Oct 7, 2:06 PM

wanpengqian_gmail.com mentioned this in D60413: bhyve: xhci: do not interrupt while the event handler is busy.Thu, Oct 8, 12:43 AM

wanpengqian_gmail.com mentioned this in D60274: bhyve: xhci: deassert INTx when no enabled interrupt is pending.

Revision Contents
Changeset List

Path

Size

usr.sbin/

bhyve/

30 lines

Diff 187018

usr.sbin/bhyve/pci_xhci.c

Loading...