Page MenuHomeFreeBSD

bhyve: usb: fix XHCI_STREAMS_MAX and stream handling
Needs ReviewPublic

Authored by kevans on Fri, Sep 18, 1:58 AM.
Tags
None
Referenced Files
F172384122: D59780.id187019.diff
Fri, Sep 18, 3:01 AM
F172378980: D59780.id187019.diff
Fri, Sep 18, 2:10 AM
F172378936: D59780.diff
Fri, Sep 18, 2:10 AM
F172378737: D59780.diff
Fri, Sep 18, 2:08 AM
Subscribers

Details

Reviewers
None
Group Reviewers
bhyve
Summary

Our previous HCCPARAMS1 encoding was actually advertising 4 streams,
as it's expressed in power-of-2 terms. In ppci_xhci_init_ep, we'd
get it wrong by not really validating MAXPSTREAMS and treating it as
the number of streams rather than the exponent for a power-of-2. That
isn't great, but at worst we may over-allocate rather than access things
out-of-bounds.

Sponsored by: The FreeBSD Foundation (aokblast)

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 77046
Build 73929: arc lint + arc unit