Page MenuHomeFreeBSD

bhyve: usb: fix XHCI_STREAMS_MAX and stream handling
AcceptedPublic

Authored by kevans on Fri, Sep 18, 1:58 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Oct 3, 10:08 PM
Unknown Object (File)
Thu, Oct 1, 8:27 AM
Unknown Object (File)
Wed, Sep 30, 10:46 PM
Unknown Object (File)
Tue, Sep 29, 12:02 PM
Unknown Object (File)
Tue, Sep 29, 10:00 AM
Unknown Object (File)
Mon, Sep 28, 9:31 PM
Unknown Object (File)
Sun, Sep 27, 8:46 AM
Unknown Object (File)
Sat, Sep 26, 5:14 PM
Subscribers

Details

Reviewers
markj
bnovkov
Group Reviewers
bhyve
Summary

Our previous HCCPARAMS1 encoding was actually advertising 4 streams,
as it's expressed in power-of-2 terms. In ppci_xhci_init_ep, we'd
get it wrong by not really validating MAXPSTREAMS and treating it as
the number of streams rather than the exponent for a power-of-2. That
isn't great, but at worst we may over-allocate rather than access things
out-of-bounds.

Sponsored by: The FreeBSD Foundation (aokblast)

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 77046
Build 73929: arc lint + arc unit