bhyve: usb: plug some leaks in bus init failure path
AcceptedPublic
Actions

Authored by kevans on Fri, Sep 18, 1:58 AM.

Details

Reviewers

markj
bnovkov

Group Reviewers

bhyve

Summary

ue_remove was never called to allow the driver to cleanup resources, so
do that now. Ignoring the error isn't great, but we don't really have
a good choice at the moment- flag it for later review.

Sponsored by: The FreeBSD Foundation (aokblast)

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 77048
Build 73931: arc lint + arc unit

Event Timeline

kevans created this revision.Fri, Sep 18, 1:58 AM

Herald added subscribers: bcran, rgrimes, imp. · View Herald TranscriptFri, Sep 18, 1:58 AM

kevans requested review of this revision.Fri, Sep 18, 1:58 AM

Harbormaster completed remote builds in B77048: Diff 187021.Fri, Sep 18, 1:58 AM

kevans added a child revision: D59783: bhyve: usb: marginally improve debugging output.Fri, Sep 18, 1:58 AM

kevans added a parent revision: D59781: bhyve: usb: devices should actually probe against the slot.Fri, Sep 18, 1:59 AM

kevans added a parent revision: D59784: bhyve: usb: handle USB 1.1 devices properly.

kevans removed a parent revision: D59781: bhyve: usb: devices should actually probe against the slot.

markj accepted this revision as: markj.Fri, Sep 18, 8:12 PM

This revision is now accepted and ready to land.Fri, Sep 18, 8:12 PM

bnovkov accepted this revision as: bnovkov.Sat, Sep 19, 10:28 AM

Revision Contents
Changeset List

Path

Size

usr.sbin/

bhyve/

pci_xhci.c

10 lines

Diff 187021

View Options

bhyve: usb: plug some leaks in bus init failure pathAcceptedPublicActions