Paths

Table of Contentst

bhyve: usb: marginally improve debugging output
AcceptedPublic
Actions

Authored by kevans on Fri, Sep 18, 1:58 AM.

Tags

None

Referenced Files

	F172559269: D59783.diff
	Sat, Sep 19, 6:35 AM

	F172543986: D59783.id.diff
	Sat, Sep 19, 3:51 AM

	F172542062: D59783.diff
	Sat, Sep 19, 3:32 AM

	F172490584: D59783.id187022.diff
	Fri, Sep 18, 8:08 PM

	F172489097: D59783.diff
	Fri, Sep 18, 7:54 PM

	F172476122: D59783.id187022.diff
	Fri, Sep 18, 6:02 PM

	F172466142: D59783.diff
	Fri, Sep 18, 4:18 PM

	Unknown Object (File)
	Fri, Sep 18, 2:19 AM

Subscribers

Details

Reviewers

markj
bnovkov

Group Reviewers

bhyve

Summary

Note when we pci_xhci_assert_interrupt, and add the trb type to
pci_xhci_cmd_reset_ep. These are both relatively straightforward.

Sponsored by: The FreeBSD Foundation (aokblast)

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 77049
Build 73932: arc lint + arc unit

Event Timeline

kevans created this revision.Fri, Sep 18, 1:58 AM

Herald added subscribers: bcran, rgrimes, imp. · View Herald TranscriptFri, Sep 18, 1:58 AM

kevans requested review of this revision.Fri, Sep 18, 1:58 AM

Harbormaster completed remote builds in B77049: Diff 187022.Fri, Sep 18, 1:58 AM

kevans added a parent revision: D59782: bhyve: usb: plug some leaks in bus init failure path.Fri, Sep 18, 1:58 AM

kevans added a child revision: D59785: bhyve: usb: properly handle port init/deinit/power-on.Fri, Sep 18, 2:28 AM

markj accepted this revision as: markj.Fri, Sep 18, 8:12 PM

This revision is now accepted and ready to land.Fri, Sep 18, 8:12 PM

One minor comment, LGTM otherwise.

usr.sbin/bhyve/pci_xhci.c
1208	Maybe it would make sense to add an `%s` modifier to the `DPRINTF` macro.

Revision Contents
Changeset List

Path

Size

usr.sbin/

bhyve/

pci_xhci.c

6 lines

Diff 187022

View Options

bhyve: usb: marginally improve debugging outputAcceptedPublicActions