Paths

Table of Contentst

LinuxKPI: Add devm_memremap and devm_ioremap_wc functions
ClosedPublic
Actions

Authored by wulf on Wed, Sep 16, 5:37 PM.

Details

Reviewers

bz
emaste
dumbbell

Commits

rG54b5d177aa98: LinuxKPI: Add devm_memremap and devm_ioremap_wc functions

Summary

Required by drm-kmod 6.12.101. Their usage was reverted later though.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 77031
Build 73914: arc lint + arc unit

Event Timeline

wulf created this revision.Wed, Sep 16, 5:37 PM

Herald added subscribers: linuxkpi, imp. · View Herald TranscriptWed, Sep 16, 5:37 PM

wulf requested review of this revision.Wed, Sep 16, 5:37 PM

Harbormaster completed remote builds in B76982: Diff 186893.Wed, Sep 16, 5:37 PM

The patch looks good to me. Just one comment about a return value of linuxkpi_devm_memremap.

sys/compat/linuxkpi/common/src/linux_page.c
453–454	On Linux 6.15, they return `ERR_PTR(-ENOMEM)`. Perhaps, it’s different in other versions?

This revision now requires changes to proceed.Thu, Sep 17, 5:35 PM

wulf marked an inline comment as done.Thu, Sep 17, 5:55 PM

wulf added inline comments.

sys/compat/linuxkpi/common/src/linux_page.c
453–454	In Linux 7.3-rc3 `ERR_PTR(-ENXIO)` is returned: https://elixir.bootlin.com/linux/v7.3-rc3/source/kernel/iomem.c#L153

oops.

sys/compat/linuxkpi/common/src/linux_page.c
453–454	ooops `ERR_PTR(-ENOMEM)` really

return ERR_PTR(-ENOMEM) if devres_alloc() has failed

Harbormaster completed remote builds in B77031: Diff 186982.Thu, Sep 17, 6:02 PM

bz accepted this revision.Thu, Sep 17, 6:12 PM

bz added inline comments.

sys/compat/linuxkpi/common/include/linux/io.h
535	If you wanted you could remove vertical space (blank line) here?

vertical space (blank line) is removed

Harbormaster completed remote builds in B77032: Diff 186984.Thu, Sep 17, 6:16 PM

dumbbell accepted this revision.Thu, Sep 17, 7:20 PM

This revision is now accepted and ready to land.Thu, Sep 17, 7:20 PM

Closed by commit rG54b5d177aa98: LinuxKPI: Add devm_memremap and devm_ioremap_wc functions (authored by wulf). · Explain WhyFri, Sep 18, 6:52 AM

This revision was automatically updated to reflect the committed changes.

wulf added a commit: rG54b5d177aa98: LinuxKPI: Add devm_memremap and devm_ioremap_wc functions.

Revision Contents
Changeset List

Path

Size

sys/

compat/

linuxkpi/

common/

include/

linux/

io.h

15 lines

src/

linux_page.c

30 lines

Diff 186982

View Options

sys/compat/linuxkpi/common/include/linux/io.h