Page MenuHomeFreeBSD
Differential D59205

rtwn: add support for the RTL8723BU
ClosedPublic
Actions

Authored by vexeduxr on Thu, Aug 27, 2:40 AM.
Tags
None
Referenced Files
F170111147: D59205.diff
Thu, Sep 3, 1:22 PM
F170071044: D59205.diff
Thu, Sep 3, 10:37 AM
Unknown Object (File)
Wed, Sep 2, 12:26 PM
Unknown Object (File)
Wed, Sep 2, 12:22 PM
Unknown Object (File)
Wed, Sep 2, 12:20 PM
Unknown Object (File)
Wed, Sep 2, 10:59 AM
Unknown Object (File)
Wed, Sep 2, 8:21 AM
Unknown Object (File)
Wed, Sep 2, 3:49 AM
View All 38 Files
Subscribers
imp
ziaee

Details

Reviewers
adrian
avos
kevlo
ziaee
Group Reviewers
wireless
manpages
Commits
rG551b7c5e12bf: rtwn: add support for the RTL8723BU

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 76196
Build 73079: arc lint + arc unit

Event Timeline

vexeduxr created this revision.Thu, Aug 27, 2:40 AM
Herald added subscribers: ziaee, imp. · View Herald TranscriptThu, Aug 27, 2:40 AM
vexeduxr requested review of this revision.Thu, Aug 27, 2:40 AM
Harbormaster completed remote builds in B76196: Diff 185175.Thu, Aug 27, 2:40 AM
vexeduxr added a comment.Thu, Aug 27, 2:46 AM

Vendor driver used for reference: https://github.com/lwfinger/rtl8723bu

ziaee added a reviewer: manpages.Thu, Aug 27, 6:41 PM
ziaee added inline comments.
share/man/man4/rtwn.4
273

In roff each sentence should start on a new line, or the linter will complain.

share/man/man4/rtwn_usb.4
119

This list is 'consumer name' - 'chipset name', so this doesn't look right?

vexeduxr added inline comments.Thu, Aug 27, 6:56 PM
share/man/man4/rtwn_usb.4
119

In this case the consumer is Realtek themselves, not a third party. There are a couple other entries in the list like this.

vexeduxr updated this revision to Diff 185233.Thu, Aug 27, 7:02 PM

Move sentence to its own line

Harbormaster completed remote builds in B76225: Diff 185233.Thu, Aug 27, 7:02 PM
vexeduxr updated this revision to Diff 185237.Thu, Aug 27, 7:10 PM

Move entry to the correct place in the hardware list

Harbormaster completed remote builds in B76227: Diff 185237.Thu, Aug 27, 7:11 PM
ziaee accepted this revision.Thu, Aug 27, 7:23 PM

No comment on rest of implementation, but manpage looks good to me.

This revision is now accepted and ready to land.Thu, Aug 27, 7:23 PM
adrian added a comment.Thu, Aug 27, 7:27 PM

i'm pretty sure we can check in binary files nowdays; i won't do it as part of this commit but I'll go review moving the uuencoded firmware files to binary files in a separate diff.

adrian added inline comments.Thu, Aug 27, 7:37 PM
sys/dev/rtwn/rtl8723b/r23b_calib.c
5

is there any reason not to use your @freebsd.org account?

sys/dev/rtwn/rtl8812a/r12a_tx_desc.h
118

which field in txdw6 ? Add a comment on which bitfields to tinker with later.

vexeduxr added inline comments.Thu, Aug 27, 7:45 PM
sys/dev/rtwn/rtl8723b/r23b_calib.c
5

I guess not. There are files in the tree marked with this email from before I got a commit bit, and I wanted to remain consistent.

Maybe I should just change the older ones...

vexeduxr updated this revision to Diff 185348.Fri, Aug 28, 2:32 PM

Change email in copyright notices and document which bits of txdw6 are passed through.

This revision now requires review to proceed.Fri, Aug 28, 2:32 PM
Harbormaster completed remote builds in B76276: Diff 185348.Fri, Aug 28, 2:32 PM
ziaee added inline comments.Fri, Aug 28, 3:58 PM
sys/dev/rtwn/rtl8723b/r23b_calib.c
2–27

While we're doing the copyright dance, we updated the preferred license representation for new files, please take a look: https://docs.freebsd.org/en/articles/license-guide/

Notes:

  1. the hyphen at the beginning is removed, that was for a project which never worked and abandoned long ago
  2. copyright line comes first
  3. the entire text of the license is already included with freebsd so it does not need to be duplicated since we can express it unambiguously. this is in line ISO standards and also is what linux does.
sys/dev/rtwn/rtl8723b/r23b_fw.c
2–27

Ditto

sys/dev/rtwn/rtl8723b/r23b_fw_cmd.h
2–27

Ditto

sys/dev/rtwn/rtl8723b/r23b_init.c
2–27

Ditto

sys/dev/rtwn/rtl8723b/r23b_led.c
2–27

Ditto

sys/dev/rtwn/rtl8723b/r23b_priv.h
2–27

Ditto

sys/dev/rtwn/rtl8723b/r23b_reg.h
2–27

Ditto

sys/dev/rtwn/rtl8723b/r23b_rf.c
2–27

Ditto

sys/dev/rtwn/rtl8723b/r23b_rom.c
2–27

Ditto

sys/dev/rtwn/rtl8723b/r23b_rom_defs.h
2–27

Ditto

sys/dev/rtwn/rtl8723b/r23b_rom_image.h
2–27

Ditto

sys/dev/rtwn/rtl8723b/r23b_rx.c
2–27

Ditto

sys/dev/rtwn/rtl8723b/r23b_var.h
2–27

Ditto

sys/dev/rtwn/rtl8723b/usb/r23bu.h
2–27

Ditto

sys/dev/rtwn/rtl8723b/usb/r23bu_attach.c
2–27

Ditto

sys/dev/rtwn/rtl8723b/usb/r23bu_init.c
2

No hyphen here

sys/dev/rtwn/rtl8723b/usb/r23bu_rom.c
2–27

Ditto

vexeduxr added inline comments.Fri, Aug 28, 10:17 PM
sys/dev/rtwn/rtl8723b/r23b_calib.c
2–27

Ah, I do vaguely remember reading about that. I'll fix it up.

Thanks.

vexeduxr updated this revision to Diff 185369.Fri, Aug 28, 11:31 PM

Update license text.

Also move the 8723b entry to the correct place in the Makefiles and include
header files in SRCS.

Harbormaster completed remote builds in B76287: Diff 185369.Fri, Aug 28, 11:31 PM
ziaee accepted this revision.Sat, Aug 29, 2:26 AM

Thanks! No comment on rest of implementation, but manpage looks good to me!

This revision is now accepted and ready to land.Sat, Aug 29, 2:26 AM
avos accepted this revision.Sun, Aug 30, 3:23 PM

Looks good to me

adrian accepted this revision.Tue, Sep 1, 7:41 PM

boot tested on this laptop; associated and works. Getting 10mbit down and 6mbit up on speedtest.net speedtest on my busy 2GHz air. It looks like it hovers around MCS3/MCS4 here but that's likely distance/busy air.

rtwn0: <Realtek 802.11n WLAN Adapter, class 239/2, rev 2.10/2.00, addr 1> on usbus0
rtwn0: MAC/BB RTL8723BU, RF 6052 1T1R

So yup, approved! please land it when you're ready.

Closed by commit rG551b7c5e12bf: rtwn: add support for the RTL8723BU (authored by vexeduxr). · Explain WhyTue, Sep 1, 9:44 PM
This revision was automatically updated to reflect the committed changes.
vexeduxr added a commit: rG551b7c5e12bf: rtwn: add support for the RTL8723BU.

Revision Contents
Changeset List

PathSize
share/
man/
man4/
7 lines
5 lines
sys/
conf/
11 lines
contrib/
dev/
rtwn/
717 lines
dev/
rtwn/
rtl8723b/
80 lines
641 lines
102 lines
76 lines
256 lines
66 lines
232 lines
84 lines
108 lines
154 lines
38 lines
101 lines
85 lines
39 lines
usb/
43 lines
218 lines
364 lines
64 lines
rtl8812a/
5 lines
usb/
11 lines
modules/
rtwn/
4 lines
rtwn_usb/
3 lines
rtwnfw/
2 lines
rtwnrtl8723bu/
4 lines

Diff 185175

View Options

share/man/man4/rtwn.4

Loading...
View Options

share/man/man4/rtwn_usb.4

Loading...
View Options

sys/conf/files

Loading...
View Options

sys/contrib/dev/rtwn/rtwn-rtl8723bufw.fw.uu

Loading...
View Options

sys/dev/rtwn/rtl8723b/r23b.h

Loading...
View Options

sys/dev/rtwn/rtl8723b/r23b_calib.c

Loading...
View Options

sys/dev/rtwn/rtl8723b/r23b_fw.c

Loading...
View Options

sys/dev/rtwn/rtl8723b/r23b_fw_cmd.h

Loading...
View Options

sys/dev/rtwn/rtl8723b/r23b_init.c

Loading...
View Options

sys/dev/rtwn/rtl8723b/r23b_led.c

Loading...
View Options

sys/dev/rtwn/rtl8723b/r23b_priv.h

Loading...
View Options

sys/dev/rtwn/rtl8723b/r23b_reg.h

Loading...
View Options

sys/dev/rtwn/rtl8723b/r23b_rf.c

Loading...
View Options

sys/dev/rtwn/rtl8723b/r23b_rom.c

Loading...
View Options

sys/dev/rtwn/rtl8723b/r23b_rom_defs.h

Loading...
View Options

sys/dev/rtwn/rtl8723b/r23b_rom_image.h

Loading...
View Options

sys/dev/rtwn/rtl8723b/r23b_rx.c

Loading...
View Options

sys/dev/rtwn/rtl8723b/r23b_var.h

Loading...
View Options

sys/dev/rtwn/rtl8723b/usb/r23bu.h

Loading...
View Options

sys/dev/rtwn/rtl8723b/usb/r23bu_attach.c

Loading...
View Options

sys/dev/rtwn/rtl8723b/usb/r23bu_init.c

Loading...
View Options

sys/dev/rtwn/rtl8723b/usb/r23bu_rom.c

Loading...
View Options

sys/dev/rtwn/rtl8812a/r12a_tx_desc.h

Loading...
View Options

sys/dev/rtwn/usb/rtwn_usb_attach.h

Loading...
View Options

sys/modules/rtwn/Makefile

Loading...
View Options

sys/modules/rtwn_usb/Makefile

Loading...
View Options

sys/modules/rtwnfw/Makefile

Loading...
View Options

sys/modules/rtwnfw/rtwnrtl8723bu/Makefile

Loading...