pdkill(2), pdgetpid(2): return EBADF if the file type is not procdesc
ClosedPublic
Actions

Authored by kib on Aug 5 2026, 8:09 AM.

Details

Reviewers

markj
lwhsu

Commits

rGdfdd8af5a8de: pddupfd.2: fix errno value returned for non-procdesc argument
rGe8b9b6b9f31c: pdkill(2), pdgetpid(2): return EBADF if the file type is not procdesc

Summary

For pdwait(2) and pddupfd(2), the returned error is kept EINVAL.

PR:     297293

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kib created this revision.Aug 5 2026, 8:09 AM

Herald added subscribers: olce, imp. · View Herald TranscriptAug 5 2026, 8:09 AM

kib requested review of this revision.Aug 5 2026, 8:09 AM

Why not return EBADF unconditionally?

This revision is now accepted and ready to land.Aug 5 2026, 1:18 PM

In D58666#1346162, @markj wrote:

Why not return EBADF unconditionally?

In e18844223d1eabb7e435ff9da20d88915d3f4675 I changed from unconditional EBADF to unconditional EINVAL, because pdwait::einval test caught it.
Changing it back seems to be not an option.

In D58666#1346166, @kib wrote:

In D58666#1346162, @markj wrote:

Why not return EBADF unconditionally?

In e18844223d1eabb7e435ff9da20d88915d3f4675 I changed from unconditional EBADF to unconditional EINVAL, because pdwait::einval test caught it.
Changing it back seems to be not an option.

Yes, pdwait::einval and pdwait(2) are already in 15.1-R so we need to keep EINVAL in 15.x (I don't object having EBADF in 16 if that makes more sense.)

BTW in lib/libsys/pdfork.2 we still say pddupfd(2) returns EBADF. In this patch we change it to EINVAL. It's only in main so I think we can just choose preferred one and sync the manpage.