pdkill(2), pdgetpid(2): return EBADF if the file type is not procdesc

[kib]

Summary

For pdwait(2) and pddupfd(2), the returned error is kept EINVAL.

PR:     297293

[markj]

Why not return EBADF unconditionally?

[kib]

In D58666#1346162, @markj wrote:

Why not return EBADF unconditionally?

In e18844223d1eabb7e435ff9da20d88915d3f4675 I changed from unconditional EBADF to unconditional EINVAL, because pdwait::einval test caught it.
Changing it back seems to be not an option.

[lwhsu]

In D58666#1346166, @kib wrote:

In D58666#1346162, @markj wrote:

Why not return EBADF unconditionally?

In e18844223d1eabb7e435ff9da20d88915d3f4675 I changed from unconditional EBADF to unconditional EINVAL, because pdwait::einval test caught it.
Changing it back seems to be not an option.

Yes, pdwait::einval and pdwait(2) are already in 15.1-R so we need to keep EINVAL in 15.x (I don't object having EBADF in 16 if that makes more sense.)

BTW in lib/libsys/pdfork.2 we still say pddupfd(2) returns EBADF. In this patch we change it to EINVAL. It's only in main so I think we can just choose preferred one and sync the manpage.

[kib]

Correct pddupfd.2

[lwhsu]

Thanks and confirmed konsole(1) doesn't report false shell crash now.