routing: Add tests for metric
ClosedPublic
Actions

Authored by pouria on Fri, May 15, 2:09 PM.

Details

Reviewers

melifaro
glebius
markj

Group Reviewers

network

Commits

rGbc301fee4cb2: routing: Add tests for metric

Summary

Add tests to make sure:

Default metric is enforced.
Lowest metric wins.
Deleting routes by specifying gateway/metric works.

Depends on D57011

Test Plan

# kyua test -k /usr/tests/Kyuafile sys/net/routing/test_routing
sys/net/routing/test_routing:add_default_metric  ->  passed  [0.084s]
sys/net/routing/test_routing:add_lowest_metric  ->  passed  [0.111s]
sys/net/routing/test_routing:delete_route_with_metric  ->  passed  [0.174s]

Results file id is usr_tests.20260515-140531-295066
Results saved to /root/.kyua/store/results.usr_tests.20260515-140531-295066.db

3/3 passed (0 broken, 0 failed, 0 skipped)

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Warnings

Severity	Location	Code	Message
Warning	tests/sys/net/routing/test_routing.sh:	CHMOD1	Invalid Executable

Unit

No Test Coverage

Build Status

Buildable 73198
Build 70081: arc lint + arc unit

Event Timeline

pouria created this revision.Fri, May 15, 2:09 PM

Herald added subscribers: ae, imp. · View Herald TranscriptFri, May 15, 2:09 PM

pouria requested review of this revision.Fri, May 15, 2:09 PM

Harbormaster completed remote builds in B73128: Diff 177887.Fri, May 15, 2:09 PM

pouria added a parent revision: D57007: routing: Allow nhop reuse in nhgrp with different metric.Fri, May 15, 2:11 PM

pouria added parent revisions: D56335: route(8): Add metric argument, D56325: route(8): Show metric value in get route.Sun, May 17, 6:50 PM

All of these tests create a single jail and operate on it. But we could instead use execenv=jail and get kyua to create the VNET jail for us. Then:

the tests would be simpler,
the tests can be run in parallel.

tests/sys/net/routing/test_routing.sh
2	I was told not to add this line, the makefiles will do that automatically.
37	This needs to be set in all of the test cases.
55	You only use the `prefix` variable here, so it'd be clearer to just define `laddr="3fff::1"` and use that here.
79	maybe? Or go further and validate the error message.
106	Same comment about `prefix`.
121
124	This is verifying the weight too, right?
136