Page MenuHomeFreeBSD
Differential D56656

Makefile.inc1: Use ln -n instead of ln -h
ClosedPublic
Actions

Authored by ivy on Apr 27 2026, 4:44 AM.
Tags
None
Referenced Files
F171371503: D56656.diff
Thu, Sep 10, 6:16 PM
Unknown Object (File)
Wed, Sep 9, 5:09 PM
Unknown Object (File)
Tue, Sep 8, 6:24 PM
Unknown Object (File)
Tue, Sep 8, 10:45 AM
Unknown Object (File)
Sun, Sep 6, 9:06 PM
Unknown Object (File)
Sun, Sep 6, 8:38 PM
Unknown Object (File)
Sun, Sep 6, 6:22 PM
Unknown Object (File)
Sun, Sep 6, 8:15 AM
View All 97 Files
Subscribers
emaste
imp
jrtc27

Details

Reviewers
imp
wosch
emaste
Group Reviewers
pkgbase
Commits
rG0851f28403e3: Makefile.inc1: Use ln -n instead of ln -h
rGd455c4bb69ec: Makefile.inc1: Use ln -n instead of ln -h
Summary

We support both -h and -n, but GNU coreutils only supports -n. This fixes the package build on Linux.

MFC after: 2 weeks
Sponsored by: https://www.patreon.com/bsdivy

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 72585
Build 69468: arc lint + arc unit

Event Timeline

ivy created this revision.Apr 27 2026, 4:44 AM
Herald added subscribers: emaste, imp. · View Herald TranscriptApr 27 2026, 4:44 AM
ivy requested review of this revision.Apr 27 2026, 4:44 AM
Harbormaster completed remote builds in B72563: Diff 176605.Apr 27 2026, 4:44 AM
imp accepted this revision.Apr 27 2026, 5:21 AM
This revision is now accepted and ready to land.Apr 27 2026, 5:21 AM
wosch accepted this revision.Apr 27 2026, 8:24 AM
emaste added a comment.Apr 27 2026, 4:26 PM

Might be nice to have something like ${LN_SYMLINK_FLAGS} set to -Tfs or -hfs. I didn't find other obvious instances in the tree though so perhaps not worth effort right now

emaste mentioned this in D52883: pkg-stage: Improve symlink creation.Apr 27 2026, 6:26 PM
emaste added a subscriber: jrtc27.Apr 27 2026, 7:04 PM

ln -n per @jrtc27 in D52883?

ivy retitled this revision from Makefile.inc1: Use ln -T instead of ln -h on Linux to Makefile.inc1: Use ln -n instead of ln -h.Apr 27 2026, 7:36 PM
ivy edited the summary of this revision. (Show Details)
ivy updated this revision to Diff 176668.Apr 27 2026, 7:36 PM

use ln -n instead

This revision now requires review to proceed.Apr 27 2026, 7:36 PM
Harbormaster completed remote builds in B72585: Diff 176668.Apr 27 2026, 7:36 PM
emaste accepted this revision.Apr 27 2026, 7:45 PM
This revision is now accepted and ready to land.Apr 27 2026, 7:45 PM
Closed by commit rGd455c4bb69ec: Makefile.inc1: Use ln -n instead of ln -h (authored by ivy). · Explain WhyApr 27 2026, 10:06 PM
This revision was automatically updated to reflect the committed changes.
ivy added a commit: rGd455c4bb69ec: Makefile.inc1: Use ln -n instead of ln -h.
ivy added a commit: rG0851f28403e3: Makefile.inc1: Use ln -n instead of ln -h.Jul 25 2026, 1:08 PM

Revision Contents
Changeset List

PathSize
2 lines

Diff 176668

View Options

Makefile.inc1

Loading...