Makefile.inc1: Always use ${PKG_CMD}
ClosedPublic
Actions

Authored by ivy on Mon, Apr 27, 4:44 AM.

Details

Reviewers

wosch
emaste

Group Reviewers

pkgbase

Commits

rGb866d05ea286: Makefile.inc1: Always use ${PKG_CMD}

Summary

Previously we had a mix of ${PKG_CMD} and bare 'pkg', which is
wrong, and breaks the build when 'pkg' isn't in the tools path,
e.g. when cross-building.

MFC after: 2 weeks
Sponsored by: https://www.patreon.com/bsdivy

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 72562
Build 69445: arc lint + arc unit

Event Timeline

ivy created this revision.Mon, Apr 27, 4:44 AM

Herald added subscribers: emaste, imp. · View Herald TranscriptMon, Apr 27, 4:44 AM

ivy requested review of this revision.Mon, Apr 27, 4:44 AM

Harbormaster completed remote builds in B72562: Diff 176604.Mon, Apr 27, 4:44 AM

wosch accepted this revision.Mon, Apr 27, 8:25 AM

This revision is now accepted and ready to land.Mon, Apr 27, 8:25 AM

emaste accepted this revision.Mon, Apr 27, 2:20 PM

Closed by commit rGb866d05ea286: Makefile.inc1: Always use ${PKG_CMD} (authored by ivy). · Explain WhyMon, Apr 27, 10:06 PM

This revision was automatically updated to reflect the committed changes.

ivy added a commit: rGb866d05ea286: Makefile.inc1: Always use ${PKG_CMD}.

Revision Contents
Changeset List

Path

Size

Makefile.inc1

8 lines

Diff 176604

View Options

Makefile.inc1: Always use ${PKG_CMD}ClosedPublicActions