Page MenuHomeFreeBSD
Differential D56537

vt_core: make sure the driver's functions exist
AbandonedPublic
Actions

Authored by vexeduxr on Mon, Apr 20, 8:28 PM.
Tags
None
Referenced Files
F154657163: D56537.diff
Wed, Apr 29, 4:03 AM
Unknown Object (File)
Tue, Apr 28, 11:07 AM
Unknown Object (File)
Tue, Apr 28, 10:21 AM
Unknown Object (File)
Mon, Apr 27, 11:22 AM
Unknown Object (File)
Mon, Apr 27, 10:20 AM
Unknown Object (File)
Mon, Apr 27, 10:05 AM
Unknown Object (File)
Sun, Apr 26, 6:39 AM
Unknown Object (File)
Sat, Apr 25, 4:23 AM
View All 9 Files
Subscribers
imp
quentin.thebault_defenso.fr

Details

Reviewers
kevans
manu
emaste
dumbbell
Commits
rGd1854272b646: vt_core: make sure the driver's functions exist
Summary

These are NULL if they're not implemented. Make sure all the functions
we need are there before doing anything.

Also invert the first if statment to lessen the indentation a bit.

Reported by: Quentin Thébault <quentin.thebault@defenso.fr>
MFC after: 3 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 72523
Build 69406: arc lint + arc unit

Event Timeline

vexeduxr created this revision.Mon, Apr 20, 8:28 PM
Herald added a subscriber: imp. · View Herald TranscriptMon, Apr 20, 8:28 PM
vexeduxr requested review of this revision.Mon, Apr 20, 8:28 PM
Harbormaster completed remote builds in B72385: Diff 175941.Mon, Apr 20, 8:28 PM
vexeduxr edited the summary of this revision. (Show Details)Mon, Apr 20, 8:34 PM
quentin.thebault_defenso.fr added a subscriber: quentin.thebault_defenso.fr.Tue, Apr 21, 3:34 AM
vexeduxr added a comment.Fri, Apr 24, 12:36 PM

Bump.
I'd like to get this into stable/15 before releng/15.1 branches

kevans added inline comments.Fri, Apr 24, 12:51 PM
sys/dev/vt/vt_core.c
1687–1701

I was pondering whether we really want to set VDF_SPLASH if some of this can't happen due to missing callbacks, and whether we really want to try and draw a shutdown splash if we can't blank the screen. I tend to think that bailing out entirely if vd_blank is missing is probably the right answer for both questions?

vexeduxr added inline comments.Fri, Apr 24, 1:39 PM
sys/dev/vt/vt_core.c
1687–1701

Hmm, yes. Maybe we also shouldn't blank the screen if vd_bitblt_* are missing? (depending on which one we want to call).
I'll try restructuring the function a bit.

vexeduxr updated this revision to Diff 176340.Fri, Apr 24, 2:38 PM

Don't do anything until we know that all the functions we need are present.
Also invert the first if statment to lessen the indentation.

Harbormaster completed remote builds in B72523: Diff 176340.Fri, Apr 24, 2:38 PM
vexeduxr updated this revision to Diff 176341.Fri, Apr 24, 2:42 PM

Small style tweak

Harbormaster completed remote builds in B72524: Diff 176341.Fri, Apr 24, 2:42 PM
vexeduxr edited the summary of this revision. (Show Details)Fri, Apr 24, 2:43 PM
vexeduxr edited the summary of this revision. (Show Details)
vexeduxr abandoned this revision.Sat, Apr 25, 10:00 PM

Landed, but forgot the tag the review :/
Apparently I can't mark this as closed as it hasn't been accepted.

Sorry, it's been a long day

vexeduxr added a commit: rGd1854272b646: vt_core: make sure the driver's functions exist.Sat, Apr 25, 10:00 PM
kevans added a comment.Sun, Apr 26, 3:17 AM
In D56537#1297200, @vexeduxr wrote:

Landed, but forgot the tag the review :/
Apparently I can't mark this as closed as it hasn't been accepted.

Sorry, it's been a long day

IIRC, the inability to close it was due to not having a commit associated to tag it with. You've done that now, but I think if you had it done it prior to abandoning it you would've additionally had the option to close it.

Revision Contents
Changeset List

PathSize
sys/
dev/
vt/
60 lines

Diff 176340

View Options

sys/dev/vt/vt_core.c

Loading...