Page MenuHomeFreeBSD

vt_core: make sure the driver's functions exist
Needs ReviewPublic

Authored by vexeduxr on Mon, Apr 20, 8:28 PM.
Tags
None
Referenced Files
F153968671: D56537.diff
Sat, Apr 25, 4:23 AM
Unknown Object (File)
Tue, Apr 21, 3:48 AM

Details

Summary

These are NULL if they're not implemented. Make sure all the functions
we need are there before doing anything.

Also invert the first if statment to lessen the indentation a bit.

Reported by: Quentin Thébault <quentin.thebault@defenso.fr>
MFC after: 3 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 72524
Build 69407: arc lint + arc unit

Event Timeline

Bump.
I'd like to get this into stable/15 before releng/15.1 branches

sys/dev/vt/vt_core.c
1687–1701

I was pondering whether we really want to set VDF_SPLASH if some of this can't happen due to missing callbacks, and whether we really want to try and draw a shutdown splash if we can't blank the screen. I tend to think that bailing out entirely if vd_blank is missing is probably the right answer for both questions?

sys/dev/vt/vt_core.c
1687–1701

Hmm, yes. Maybe we also shouldn't blank the screen if vd_bitblt_* are missing? (depending on which one we want to call).
I'll try restructuring the function a bit.

Don't do anything until we know that all the functions we need are present.
Also invert the first if statment to lessen the indentation.

vexeduxr edited the summary of this revision. (Show Details)