Page MenuHomeFreeBSD
Differential D56537

vt_core: make sure the driver's functions exist
AbandonedPublic
Actions

Authored by vexeduxr on Apr 20 2026, 8:28 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jun 4, 2:40 PM
Unknown Object (File)
Thu, May 28, 4:22 PM
Unknown Object (File)
Thu, May 28, 1:20 AM
Unknown Object (File)
Wed, May 27, 6:51 PM
Unknown Object (File)
Tue, May 19, 12:49 AM
Unknown Object (File)
Mon, May 18, 5:58 PM
Unknown Object (File)
Mon, May 18, 6:05 AM
Unknown Object (File)
Mon, May 18, 4:24 AM
View All 42 Files
Subscribers
imp
quentin.thebault_defenso.fr

Details

Reviewers
kevans
manu
emaste
dumbbell
Commits
rGd1854272b646: vt_core: make sure the driver's functions exist
Summary

These are NULL if they're not implemented. Make sure all the functions
we need are there before doing anything.

Also invert the first if statment to lessen the indentation a bit.

Reported by: Quentin Thébault <quentin.thebault@defenso.fr>
MFC after: 3 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 72385
Build 69268: arc lint + arc unit

Event Timeline

vexeduxr created this revision.Apr 20 2026, 8:28 PM
Herald added a subscriber: imp. · View Herald TranscriptApr 20 2026, 8:28 PM
vexeduxr requested review of this revision.Apr 20 2026, 8:28 PM
Harbormaster completed remote builds in B72385: Diff 175941.Apr 20 2026, 8:28 PM
vexeduxr edited the summary of this revision. (Show Details)Apr 20 2026, 8:34 PM
quentin.thebault_defenso.fr added a subscriber: quentin.thebault_defenso.fr.Apr 21 2026, 3:34 AM
vexeduxr added a comment.Apr 24 2026, 12:36 PM

Bump.
I'd like to get this into stable/15 before releng/15.1 branches

kevans added inline comments.Apr 24 2026, 12:51 PM
sys/dev/vt/vt_core.c
1717

I was pondering whether we really want to set VDF_SPLASH if some of this can't happen due to missing callbacks, and whether we really want to try and draw a shutdown splash if we can't blank the screen. I tend to think that bailing out entirely if vd_blank is missing is probably the right answer for both questions?

vexeduxr added inline comments.Apr 24 2026, 1:39 PM
sys/dev/vt/vt_core.c
1717

Hmm, yes. Maybe we also shouldn't blank the screen if vd_bitblt_* are missing? (depending on which one we want to call).
I'll try restructuring the function a bit.

vexeduxr updated this revision to Diff 176340.Apr 24 2026, 2:38 PM

Don't do anything until we know that all the functions we need are present.
Also invert the first if statment to lessen the indentation.

Harbormaster completed remote builds in B72523: Diff 176340.Apr 24 2026, 2:38 PM
vexeduxr updated this revision to Diff 176341.Apr 24 2026, 2:42 PM

Small style tweak

Harbormaster completed remote builds in B72524: Diff 176341.Apr 24 2026, 2:42 PM
vexeduxr edited the summary of this revision. (Show Details)Apr 24 2026, 2:43 PM
vexeduxr edited the summary of this revision. (Show Details)
vexeduxr abandoned this revision.Apr 25 2026, 10:00 PM

Landed, but forgot the tag the review :/
Apparently I can't mark this as closed as it hasn't been accepted.

Sorry, it's been a long day

vexeduxr added a commit: rGd1854272b646: vt_core: make sure the driver's functions exist.Apr 25 2026, 10:00 PM
kevans added a comment.Apr 26 2026, 3:17 AM
In D56537#1297200, @vexeduxr wrote:

Landed, but forgot the tag the review :/
Apparently I can't mark this as closed as it hasn't been accepted.

Sorry, it's been a long day

IIRC, the inability to close it was due to not having a commit associated to tag it with. You've done that now, but I think if you had it done it prior to abandoning it you would've additionally had the option to close it.

Revision Contents
Changeset List

PathSize
sys/
dev/
vt/
20 lines

Diff 175941

View Options

sys/dev/vt/vt_core.c

Loading...