Page MenuHomeFreeBSD
Differential D56135

nd6: Break nd6_prefix_lifetime_update out of prelist_update
Needs ReviewPublic
Actions

Authored by pouria on Sat, Mar 28, 8:14 PM.
Tags
None
Referenced Files
F152526263: D56135.id174851.diff
Wed, Apr 15, 12:12 PM
F152518523: D56135.id174459.diff
Wed, Apr 15, 11:16 AM
Unknown Object (File)
Wed, Apr 15, 2:53 AM
Unknown Object (File)
Tue, Apr 14, 11:02 AM
Unknown Object (File)
Sun, Apr 12, 9:04 PM
Unknown Object (File)
Sun, Apr 12, 5:07 PM
Unknown Object (File)
Sun, Apr 12, 1:45 PM
Unknown Object (File)
Sun, Apr 12, 4:19 AM
View All 23 Files
Subscribers
ae
imp
melifaro

Details

Reviewers
markj
glebius
bz
Group Reviewers
network
Summary

Logic of updating prefix lifetime is big enough that deserves
its own function.
While here, fix style.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 71914
Build 68797: arc lint + arc unit

Event Timeline

pouria created this revision.Sat, Mar 28, 8:14 PM
Herald added subscribers: melifaro, ae, imp. · View Herald TranscriptSat, Mar 28, 8:14 PM
pouria requested review of this revision.Sat, Mar 28, 8:14 PM
Harbormaster completed remote builds in B71783: Diff 174459.Sat, Mar 28, 8:14 PM
pouria added a parent revision: D56134: nd6: Remove anycast check in prelist_update.Sat, Mar 28, 8:14 PM
pouria added a child revision: D56136: nd6: Remove goto and unused condition in prelist_update.
pouria retitled this revision from ndp: Break nd6_prefix_lifetime_update out of prelist_update to nd6: Break nd6_prefix_lifetime_update out of prelist_update.Wed, Apr 1, 4:36 PM
markj added inline comments.Thu, Apr 2, 9:46 AM
sys/netinet6/nd6_rtr.c
1589

These lines look too long. I think you can simplify the code a bit by storing time_uptime - ia6->ia6_createtime in a local variable.

pouria updated this revision to Diff 174803.Thu, Apr 2, 11:27 AM
pouria marked an inline comment as done.

Address @markj comment.
Thank you

Harbormaster completed remote builds in B71914: Diff 174803.Thu, Apr 2, 11:27 AM
markj added inline comments.Fri, Apr 3, 7:29 AM
sys/netinet6/nd6_rtr.c
1589

Further simplification: set vltime = time_uptime - ia6->ia6_createtime + V_ip6_desync_factor.

pouria updated this revision to Diff 174851.Fri, Apr 3, 1:09 PM

Address @markj comment

Harbormaster completed remote builds in B71931: Diff 174851.Fri, Apr 3, 1:09 PM
pouria marked an inline comment as done.Fri, Apr 3, 1:09 PM

Revision Contents
Changeset List

PathSize
sys/
netinet6/
208 lines

Diff 174803

View Options

sys/netinet6/nd6_rtr.c

Loading...