Page MenuHomeFreeBSD

nd6: Ignore entire PI if violates RFC 4862 section 5.5.3
Needs ReviewPublic

Authored by pouria on Sat, Mar 28, 8:13 PM.
Tags
None
Referenced Files
F151969084: D56133.id174748.diff
Sat, Apr 11, 8:26 PM
F151966629: D56133.id.diff
Sat, Apr 11, 8:05 PM
Unknown Object (File)
Thu, Apr 9, 12:20 PM
Unknown Object (File)
Wed, Apr 8, 6:04 PM
Unknown Object (File)
Wed, Apr 8, 10:00 AM
Unknown Object (File)
Tue, Apr 7, 11:37 PM
Unknown Object (File)
Tue, Apr 7, 9:38 AM
Unknown Object (File)
Tue, Apr 7, 1:44 AM

Details

Reviewers
markj
glebius
bz
ae
Group Reviewers
network
Summary

Ignore prefix information update earlier in prelist_update().
If PI is invalid or autonomous bit is unset, we better to let our
SLAAC address expire.
If we don't have any previous matching prefix, better not to create new one.
Because either our router don't want us to have one anymore, or the very
RA is malicious.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 71911
Build 68794: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Sun, Mar 29, 5:00 PM
zlei added inline comments.
sys/netinet6/nd6_rtr.c
1553

Remove this stale comment as well ?

1588

The previous comment confuses me a bit. Why pr must be non NULL at this point ?

pouria retitled this revision from ndp: Ignore entire PI if violates RFC 4862 section 5.5.3 to nd6: Ignore entire PI if violates RFC 4862 section 5.5.3.Wed, Apr 1, 4:07 PM
pouria marked an inline comment as done.

Address @zlei comment.

This revision now requires review to proceed.Wed, Apr 1, 4:32 PM