Page MenuHomeFreeBSD
Differential D56134

nd6: Remove anycast check in prelist_update
AcceptedPublic
Actions

Authored by pouria on Sat, Mar 28, 8:13 PM.
Tags
None
Referenced Files
F151822565: D56134.id.diff
Fri, Apr 10, 9:55 PM
Unknown Object (File)
Thu, Apr 9, 1:32 PM
Unknown Object (File)
Thu, Apr 9, 1:44 AM
Unknown Object (File)
Wed, Apr 8, 10:00 AM
Unknown Object (File)
Tue, Apr 7, 8:05 AM
Unknown Object (File)
Mon, Apr 6, 6:08 AM
Unknown Object (File)
Sun, Apr 5, 4:05 AM
Unknown Object (File)
Fri, Apr 3, 10:24 PM
View All 13 Files
Subscribers
ae
imp
melifaro
zlei

Details

Reviewers
markj
glebius
bz
zlei
Group Reviewers
network
Summary

RFC 2462 is obsoleted by RFC 4862 and it made statements more clear
than before.
Considering SLAAC can't create anycast addresses by itself, remove its check.
While here, update comments based on RFC 4862.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 71782
Build 68665: arc lint + arc unit

Event Timeline

pouria created this revision.Sat, Mar 28, 8:13 PM
Herald added subscribers: melifaro, ae, imp. · View Herald TranscriptSat, Mar 28, 8:13 PM
pouria requested review of this revision.Sat, Mar 28, 8:13 PM
Harbormaster completed remote builds in B71782: Diff 174458.Sat, Mar 28, 8:13 PM
pouria added a parent revision: D56133: nd6: Ignore entire PI if violates RFC 4862 section 5.5.3.Sat, Mar 28, 8:13 PM
pouria added a child revision: D56135: nd6: Break nd6_prefix_lifetime_update out of prelist_update.
markj accepted this revision.Wed, Apr 1, 12:44 PM
This revision is now accepted and ready to land.Wed, Apr 1, 12:44 PM
zlei accepted this revision as: zlei.Wed, Apr 1, 3:32 PM
zlei added a subscriber: zlei.

Looks sane to me.

For the commit message,

ndp: Remove anycast check in prelist_update

I think the word ndp is a bit misleading. I read it this is a change for the userspace one usr.sbin/ndp. I'd prefer nd6_rtr: xxx or nd6: xxx, to indicate the change is for the kernel part.

glebius added a comment.Wed, Apr 1, 3:41 PM
In D56134#1286016, @zlei wrote:

I think the word ndp is a bit misleading. I read it this is a change for the userspace one usr.sbin/ndp. I'd prefer nd6_rtr: xxx or nd6: xxx, to indicate the change is for the kernel part.

Yep. Unfortunately there is little consistency in the history of this file and of nd6.c as well. I'd suggest in the future to stick to nd6: or netinet6: if the change is touching more than just ND part of IPv6.

pouria added a comment.Wed, Apr 1, 4:03 PM
In D56134#1286016, @zlei wrote:

For the commit message,

ndp: Remove anycast check in prelist_update

I think the word ndp is a bit misleading. I read it this is a change for the userspace one usr.sbin/ndp. I'd prefer nd6_rtr: xxx or nd6: xxx, to indicate the change is for the kernel part.

Thank you for your review, I'll change I commit messages to nd6:

pouria retitled this revision from ndp: Remove anycast check in prelist_update to nd6: Remove anycast check in prelist_update.Wed, Apr 1, 4:06 PM

Revision Contents
Changeset List

PathSize
sys/
netinet6/
25 lines

Diff 174458

View Options

sys/netinet6/nd6_rtr.c

Loading...