Page MenuHomeFreeBSD
Differential D56133

nd6: Ignore entire PI if violates RFC 4862 section 5.5.3
Needs ReviewPublic
Actions

Authored by pouria on Sat, Mar 28, 8:13 PM.
Tags
None
Referenced Files
F152171589: D56133.diff
Mon, Apr 13, 5:28 AM
F152103651: D56133.id174457.diff
Sun, Apr 12, 6:22 PM
Unknown Object (File)
Sat, Apr 11, 8:26 PM
Unknown Object (File)
Sat, Apr 11, 8:05 PM
Unknown Object (File)
Thu, Apr 9, 12:20 PM
Unknown Object (File)
Wed, Apr 8, 6:04 PM
Unknown Object (File)
Wed, Apr 8, 10:00 AM
Unknown Object (File)
Tue, Apr 7, 11:37 PM
View All 16 Files
Subscribers
ae
glebius
imp
melifaro
zlei

Details

Reviewers
markj
bz
ae
glebius
Group Reviewers
network
Summary

Ignore prefix information update earlier in prelist_update().
If PI is invalid or autonomous bit is unset, we better to let our
SLAAC address expire.
If we don't have any previous matching prefix, better not to create new one.
Because either our router don't want us to have one anymore, or the very
RA is malicious.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 71781
Build 68664: arc lint + arc unit

Event Timeline

pouria created this revision.Sat, Mar 28, 8:13 PM
Herald added subscribers: melifaro, ae, imp. · View Herald TranscriptSat, Mar 28, 8:13 PM
pouria requested review of this revision.Sat, Mar 28, 8:13 PM
Harbormaster completed remote builds in B71781: Diff 174457.Sat, Mar 28, 8:13 PM
pouria added a parent revision: D56132: nd6: Change prelist_update() return type to void.Sat, Mar 28, 8:13 PM
pouria added a child revision: D56134: nd6: Remove anycast check in prelist_update.
ae accepted this revision as: ae.Sun, Mar 29, 5:00 PM
This revision is now accepted and ready to land.Sun, Mar 29, 5:00 PM
zlei added a subscriber: zlei.Sun, Mar 29, 5:46 PM
zlei added inline comments.
sys/netinet6/nd6_rtr.c
1553

Remove this stale comment as well ?

1588

The previous comment confuses me a bit. Why pr must be non NULL at this point ?

pouria retitled this revision from ndp: Ignore entire PI if violates RFC 4862 section 5.5.3 to nd6: Ignore entire PI if violates RFC 4862 section 5.5.3.Wed, Apr 1, 4:07 PM
pouria updated this revision to Diff 174748.Wed, Apr 1, 4:32 PM
pouria marked an inline comment as done.

Address @zlei comment.

This revision now requires review to proceed.Wed, Apr 1, 4:32 PM
Harbormaster completed remote builds in B71911: Diff 174748.Wed, Apr 1, 4:32 PM
glebius resigned from this revision.Sun, Apr 12, 7:23 PM

Not an expert in the area.

Herald added a subscriber: glebius. · View Herald TranscriptSun, Apr 12, 7:23 PM

Revision Contents
Changeset List

PathSize
sys/
netinet6/
24 lines

Diff 174457

View Options

sys/netinet6/nd6_rtr.c

Loading...