Page MenuHomeFreeBSD

nd6: Change prelist_update() return type to void
AcceptedPublic

Authored by pouria on Sat, Mar 28, 8:13 PM.
Tags
None
Referenced Files
F150612753: D56132.diff
Thu, Apr 2, 7:40 PM
Unknown Object (File)
Mon, Mar 30, 7:38 PM
Unknown Object (File)
Mon, Mar 30, 6:28 PM
Unknown Object (File)
Mon, Mar 30, 1:47 PM

Details

Reviewers
markj
glebius
bz
zlei
Group Reviewers
network
Summary

The return value of prelist_update is unused.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 71780
Build 68663: arc lint + arc unit

Event Timeline

markj added inline comments.
sys/netinet6/nd6_rtr.c
1826

The return statement should just be removed.

This revision is now accepted and ready to land.Sun, Mar 29, 7:15 AM
sys/netinet6/nd6_rtr.c
1826

I've removed it in D56136.
I can remove it here too if you want.
Thanks

zlei added inline comments.
sys/netinet6/nd6_rtr.c
1605

RFC2462 -> RFC 4862.

I'd recommend split that into a different review. It is not part of Change prelist_update() return type to void, but a good commit log is useful for users those use git blame to find out why this line was changed.

Generally, for a commit, do one thing if possible.

1610

New code should use uint32_t. I would keep existing code as is, given it is not part of the change lines related to Change prelist_update() return type to void, and also only change one u_int32_t -> uint32_t does not serve much value.

I have ever had a plan to change them all, but there're too many usage.

% grep -Er 'u_int(8|16|32)_t' sys | wc -l
   51240

I abort finally, such a big change ( u_int(8|16|32)_t -> uint(8|16|32)_t ) will makes troubles when doing MFC.

pouria retitled this revision from ndp: Change prelist_update() return type to void to nd6: Change prelist_update() return type to void.Wed, Apr 1, 4:07 PM
sys/netinet6/nd6_rtr.c
1605

I verified this function conforms to the new RFC.
However, IMHO a commit that only updates a single comment line is not useful.
I'll explain it in the commit message body instead to be searchable.

1610

I'll eventually relocate many parts of this function to new one and fix their types along the way.
This will be the only old type left.
That's why I updated it here.

sys/netinet6/nd6_rtr.c
1610

I have ever had a plan to change them all, but there're too many usage.

Yes, better to remove them incrementally when making other nearby changes, like we've done with e.g., boolean_t. u_int*_t does not hurt anyone, it is not worth the churn to remove it all at once.

1826

That's fine.