Per Wikipedia, ACPI WMI support is available on all x86* platforms
and ARM platforms. Add the source to files.arm64 so code that relies
on its headers (thunderbolt(4) for instance), can be built on ARM64.
Details
Details
- Reviewers
andrew - Commits
- rG876d2b8392e6: acpi: build dev/acpi_support/acpi_wmi_if.m on ARM64
This passes make universe.
This is a part of my larger attempt/effort to see how much of my Apple Silicon-based machine boots with FreeBSD CURRENT, but this is also a requirement for building thunderbolt(4) on ARM64.
This particular change has not been runtime tested yet.
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Skipped - Unit
Tests Skipped - Build Status
Buildable 71077 Build 67960: arc lint + arc unit
Event Timeline
| sys/conf/files.arm64 | ||
|---|---|---|
| 209 | Not sure why it's standard on x86 (that's where I copied the line from), but this should be "optional acpi". | |
| sys/conf/files.arm64 | ||
|---|---|---|
| 209 | It should be under optional acpi as the kernel cam be built without ACPI support, e.g. using FDT. | |
| sys/conf/files.arm64 | ||
|---|---|---|
| 209 | Ah, yes. I forgot to update the diff -- thank you for the reminder :). | |
Comment Actions
Build the .m when acpi/acpi_wmi are explicitly requested. Don't make it
part of the standard kernel.
As @andrew rightly noted, ARM64 can be built without ACPI (FDT-based
platforms). I discovered shortly after posting the diff as the LINT-FDT
kernel target build failed make tinderbox :D.
Comment Actions
I want to give @jkim some time to look at this since the acpi_wmi part of the diff might be unnecessary.