Paths

Table of Contentst

Differential D55001

hwpstate_amd(4): Assert PSTATE_CPPC is on in corresponding sysctl handlers
ClosedPublic
Actions

Authored by olce on Sat, Jan 31, 11:46 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Feb 2, 4:19 PM

	Unknown Object (File)
	Mon, Feb 2, 3:43 AM

	Unknown Object (File)
	Sun, Feb 1, 5:53 AM

	Unknown Object (File)
	Sun, Feb 1, 3:28 AM

	Unknown Object (File)
	Sun, Feb 1, 12:58 AM

	Unknown Object (File)
	Sat, Jan 31, 8:57 PM

Subscribers

Details

Reviewers

aokblast
lwhsu
emaste

Commits

rGfa0512f7156d: hwpstate_amd(4): Assert PSTATE_CPPC is on in corresponding sysctl handlers

Summary

No functional change intended.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 70273
Build 67156: arc lint + arc unit

Event Timeline

olce created this revision.Sat, Jan 31, 11:46 AM

Herald added a subscriber: imp. · View Herald TranscriptSat, Jan 31, 11:46 AM

olce requested review of this revision.Sat, Jan 31, 11:46 AM

Harbormaster completed remote builds in B70273: Diff 170836.Sat, Jan 31, 11:46 AM

olce added a parent revision: D55000: hwpstate_amd(4): Rename register dump sysctl handler.Sat, Jan 31, 1:25 PM

olce added a child revision: D55002: hwpstate_amd(4): Rename EPP handler, convert to unsigned int.

aokblast added inline comments.Sun, Feb 1, 8:01 AM

sys/x86/cpufreq/hwpstate_amd.c
213	Can it just be a macro? I don't think inline always work. Or always inline?

olce added inline comments.Mon, Feb 2, 4:51 PM

sys/x86/cpufreq/hwpstate_amd.c
213	I think we should use functions unless we have a good reason to use macros, for type safety, single evaluations of arguments, etc. The `inline` here is anyway cosmetic, `clang` always inlines such small functions even if there's no explicit hint.

This revision was not accepted when it landed; it landed in state Needs Review.Fri, Feb 6, 4:29 PM

Closed by commit rGfa0512f7156d: hwpstate_amd(4): Assert PSTATE_CPPC is on in corresponding sysctl handlers (authored by olce). · Explain Why

This revision was automatically updated to reflect the committed changes.

olce added a commit: rGfa0512f7156d: hwpstate_amd(4): Assert PSTATE_CPPC is on in corresponding sysctl handlers.

Revision Contents
Changeset List

Path

Size

sys/

x86/

cpufreq/

15 lines

Diff 170836

sys/x86/cpufreq/hwpstate_amd.c

Loading...