Page MenuHomeFreeBSD
Differential D55009

hwpstate_amd(4): 'epp' sysctl leaf to operate on real EPP hardware values
ClosedPublic
Actions

Authored by olce on Jan 31 2026, 11:49 AM.
Tags
None
Referenced Files
F162729951: D55009.diff
Thu, Jul 16, 5:54 AM
Unknown Object (File)
Wed, Jul 15, 7:05 AM
Unknown Object (File)
Wed, Jul 15, 7:05 AM
Unknown Object (File)
Wed, Jul 15, 6:15 AM
Unknown Object (File)
Sun, Jul 5, 2:03 PM
Unknown Object (File)
Sat, Jul 4, 5:46 AM
Unknown Object (File)
Sat, Jul 4, 5:46 AM
Unknown Object (File)
Thu, Jul 2, 4:01 PM
View All 46 Files
Subscribers
cracauer
cy
imp

Details

Reviewers
aokblast
lwhsu
emaste
Commits
rG951788e3733e: hwpstate_amd(4): 'epp' sysctl leaf to operate on real EPP hardware values
Summary

We were using percents, for compatibility with hwpstate_intel(4), but
this looses granularity that might be important in some scenarios or
with specific CPU models.

For consistency, hwpstate_intel(4) should be changed accordingly, at the
expense of breaking compatibility.

PR: 292615
Sponsored by: The FreeBSD Foundation

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

olce created this revision.Jan 31 2026, 11:49 AM
Herald added a subscriber: imp. · View Herald TranscriptJan 31 2026, 11:49 AM
olce requested review of this revision.Jan 31 2026, 11:49 AM
Harbormaster completed remote builds in B70281: Diff 170844.Jan 31 2026, 11:49 AM
olce added a parent revision: D55008: hwpstate_amd(4): Factor out setting the CPPC_REQUEST register.Jan 31 2026, 1:26 PM
olce added a child revision: D55010: hwpstate_amd(4): Add knobs to get/set all fields of CPPC_REQUEST.
aokblast accepted this revision.Feb 7 2026, 3:05 AM

LGTM for me but I think we should merge the intel's one at the same time.

This revision is now accepted and ready to land.Feb 7 2026, 3:05 AM
Closed by commit rG951788e3733e: hwpstate_amd(4): 'epp' sysctl leaf to operate on real EPP hardware values (authored by olce). · Explain WhyFeb 11 2026, 8:44 PM
This revision was automatically updated to reflect the committed changes.
olce added a commit: rG951788e3733e: hwpstate_amd(4): 'epp' sysctl leaf to operate on real EPP hardware values.
olce added a comment.Feb 11 2026, 8:45 PM
In D55009#1261034, @aokblast wrote:

LGTM for me but I think we should merge the intel's one at the same time.

I agree, but unfortunately in the immediate I cannot dedicate more time to revamping the Intel driver, and I don't want to hold back these changes for a long while. Perhaps I'll leave that to you when you come back, let's talk about it then.

Revision Contents
Changeset List

PathSize
sys/
x86/
cpufreq/
21 lines

Diff 171794

View Options

sys/x86/cpufreq/hwpstate_amd.c

Loading...