Page MenuHomeFreeBSD
Differential D55005

hwpstate_amd(4): Register dump: Fine-grained error reporting
ClosedPublic
Actions

Authored by olce on Sat, Jan 31, 11:48 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Feb 19, 10:18 PM
Unknown Object (File)
Wed, Feb 18, 10:11 PM
Unknown Object (File)
Wed, Feb 18, 8:35 AM
Unknown Object (File)
Wed, Feb 18, 2:11 AM
Unknown Object (File)
Tue, Feb 17, 7:21 PM
Unknown Object (File)
Sun, Feb 15, 10:52 AM
Unknown Object (File)
Sat, Feb 14, 10:28 PM
Unknown Object (File)
Sat, Feb 14, 9:17 PM
View All 16 Files
Subscribers
cracauer
cy
imp

Details

Reviewers
aokblast
lwhsu
emaste
Commits
rG8aac1e9b028e: hwpstate_amd(4): Register dump: Fine-grained error reporting
Summary

If some of the registers cannot be read, report that but continue trying
reading the others. This also has the side benefit of simplifying code.

While here, use sbuf_new_for_sysctl(), and rename 'res' and 'ret', which
are to contain error values, to 'error'.

While here, remove the test on getting the per-cpu structure, as if it
is not present we would have already crashed on device attach.

PR: 292615
Sponsored by: The FreeBSD Foundation

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

olce created this revision.Sat, Jan 31, 11:48 AM
Herald added a subscriber: imp. · View Herald TranscriptSat, Jan 31, 11:48 AM
olce requested review of this revision.Sat, Jan 31, 11:48 AM
Harbormaster completed remote builds in B70277: Diff 170840.Sat, Jan 31, 11:48 AM
olce added a parent revision: D55004: hwpstate_amd(4): Revamp the softc.Sat, Jan 31, 1:26 PM
olce added a child revision: D55006: hwpstate_amd(4): attach(): More diagnostic on CPPC enable.
aokblast added inline comments.Sat, Feb 7, 2:49 AM
sys/x86/cpufreq/hwpstate_amd.c
269

What is the purpose of having the small function with just one sbuf_printf statement in here? I didn't see any condition that we would reuse this funtion?

aokblast accepted this revision.Sat, Feb 7, 2:52 AM

Ok I see it is reused in other patch

This revision is now accepted and ready to land.Sat, Feb 7, 2:52 AM
Closed by commit rG8aac1e9b028e: hwpstate_amd(4): Register dump: Fine-grained error reporting (authored by olce). · Explain WhyWed, Feb 11, 8:44 PM
This revision was automatically updated to reflect the committed changes.
olce added a commit: rG8aac1e9b028e: hwpstate_amd(4): Register dump: Fine-grained error reporting.

Revision Contents
Changeset List

PathSize
sys/
x86/
cpufreq/
112 lines

Diff 171790

View Options

sys/x86/cpufreq/hwpstate_amd.c

Loading...