Page MenuHomeFreeBSD

hwpstate_amd(4): Factor out printing CPPC registers, fix CPPC_REQUEST's
ClosedPublic

Authored by olce on Sat, Jan 31, 11:46 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Feb 3, 10:58 PM
Unknown Object (File)
Sun, Feb 1, 11:13 PM
Unknown Object (File)
Sun, Feb 1, 7:48 PM
Unknown Object (File)
Sat, Jan 31, 9:17 PM
Unknown Object (File)
Sat, Jan 31, 5:45 PM
Unknown Object (File)
Sat, Jan 31, 4:27 PM
Unknown Object (File)
Sat, Jan 31, 4:10 PM
Subscribers

Details

Summary

Factor out these printing, so they can be called from other places than
just the register dump handler. This also makes surrounding code
clearer.

Fix inverted printing of minimum and maximum performance.

For better diagnostic, print the full raw content of each register
before printing the value of fields we know about.

As fields are printed in decimal, remove 0-padding, which could give the
impression that the numbers are printed in octal or hexadecimal.

While here, remove superfluous blank lines when printing (we use TABs
for the different registers' fields).

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

olce requested review of this revision.Sat, Jan 31, 11:46 AM
sys/x86/cpufreq/hwpstate_amd.c
63

Should we include this?

sys/x86/cpufreq/hwpstate_amd.c
63

Yes, that's necessary for format specifiers such as PRIx64.

This revision was not accepted when it landed; it landed in state Needs Review.Fri, Feb 6, 4:29 PM
This revision was automatically updated to reflect the committed changes.