In D53910#1243475, @ziaee wrote:

I've made some content and mechanical changes in my local branch, but when I make clean website; firefox website/public/index.html renders just broken black and white.

I tend to test it locally with 'make run' (in the website directory) and point a browser at the hugo server running on port 1313. You could do 'make build' which will make the public site and should be browsable like that, I would think (I have not tested it that way, although the mock site running at freebsd.fortasse.cloud is just an rsync of the public directory running in a Caddy container)

In D53910#1241780, @jrtc27 wrote:

Just looking at the homepage there is some very strange use of whitespace: specifically, there is a lot of extra vertical whitespace in various places that look unbalanced and make the content too spread out, and there is vertical whitespace lacking in the feed headings. See the attachments for before and after fixing these oddities that make the design feel more cohesive, polished and readable.

freebsd.fortasse.cloud.pdf267 KBDownload

jrtc27-freebsd.fortasse.cloud.pdf267 KBDownload

@jrtc27 Where did you make these changes? I can see from the PDFs it is a 'nicer' look — I'd like to put your changes into this edit. Feel free to either ping me the changes as a diff, or just tell me and I'll update the files :) Many thanks!

In D53910#1241795, @adrian wrote:

hi!

The main bit of feedback I have is "please don't mix company stuff with project features." We have plenty of other large companies that contribute to freebsd; I think having a big netflix logo and only mentioning netflix in networking is doing everyone else a disservice.

I highly recommend finding a replacement image for networking, remove the Netflix mention and just mention "Many companies that power the Internet.." or something to that effect.

Thanks!

Fixed @adrian ! Many thanks for the input.

In D53910#1245453, @grahamperrin wrote:

docs not invited to review, is the omission intentional?

https://reviews.freebsd.org/project/profile/72/

People who are willing to review documentation changes (opt-in)

I should add: in my experience, omissions are most often accidental :-)

(OT: Phabricator is complicated. Discovery, including discovery of things that have human members, is sometimes not easy. I look forward to use of Forgejo.)

I am trying to keep reviewers and consensus to a 'right size' @grahamperrin :)

In D53910#1245581, @mark_freebsdfoundation.org wrote:

In D53910#1241780, @jrtc27 wrote:

Just looking at the homepage there is some very strange use of whitespace: specifically, there is a lot of extra vertical whitespace in various places that look unbalanced and make the content too spread out, and there is vertical whitespace lacking in the feed headings. See the attachments for before and after fixing these oddities that make the design feel more cohesive, polished and readable.

freebsd.fortasse.cloud.pdf267 KBDownload

jrtc27-freebsd.fortasse.cloud.pdf267 KBDownload

@jrtc27 Where did you make these changes? I can see from the PDFs it is a 'nicer' look — I'd like to put your changes into this edit. Feel free to either ping me the changes as a diff, or just tell me and I'll update the files :) Many thanks!

I just hacked it up live via Inspect Element rather than figuring out how to do it the actual website sources. Also has the benefit of giving instant feedback so it can be a more interactive process of playing around with it.

Another minor issue is visual distinction between elements. The same colour and text styling (when not hovered over) are used for headings and links here:

At least for me, my brain thinks those headings are links and wants to be able to click on them, but you can't, and don't find that out until you hover over them to try to click on them.

Links are also inconsistent. In most places they're underlined on hover, however in the "Why FreeBSD?" section they're always underlined (in fact, this is the default, they're just overridden to not be always underlined for the various other specific places):

The links in the navbar drop-downs also feel pretty "dead" (no interactivity when you hover over them) but that's an issue inherited from the docs theme.

Looking through the markup I see there are slashes placed at the end of self-closing tags such as <meta>, <link>, <img> and others (and sometimes not). But no HTML standard has ever specified that slashes be put there. This is a holdover from when people thought we'd all be using XHTML/XML for web pages. While allowed for that reason, putting a slash there has no meaning, it does nothing, is not required and browsers ignore it. If anything, the slash can cause problems for unquoted attributes. As a long time web developer, I suggest these be removed.

In D53910#1246726, @rob_belics.com wrote:

Looking through the markup I see there are slashes placed at the end of self-closing tags such as <meta>, <link>, <img> and others (and sometimes not). But no HTML standard has ever specified that slashes be put there. This is a holdover from when people thought we'd all be using XHTML/XML for web pages. While allowed for that reason, putting a slash there has no meaning, it does nothing, is not required and browsers ignore it. If anything, the slash can cause problems for unquoted attributes. As a long time web developer, I suggest these be removed.

Many thanks for this @rob_belics.com — should be fixed now! :)

You probably already do this but occasionally run the HTML through the W3C HTML Validator for that list of errors and warnings: https://validator.w3.org/nu/
And then there's the CSS Validator: https://jigsaw.w3.org/css-validator/ A lot of those vendor extensions can be removed.

In D53910#1247618, @rob_belics.com wrote:

You probably already do this but occasionally run the HTML through the W3C HTML Validator for that list of errors and warnings: https://validator.w3.org/nu/
And then there's the CSS Validator: https://jigsaw.w3.org/css-validator/ A lot of those vendor extensions can be removed.

CSS cleanup is planned after this release Rob, yes. For now we'd like to get something new out there, and iterate on it. If it's working, I'm happy :)

Really appreciate your eye for details! If you have time, please keep an eye on this and feel free to make suggestions. I'm making a post-implementation todo list of 'none blocking' things that can be addressed later. Once it's gone live and is in the proper docs git repository it'll be much easier for everyone to make contributions too, which is what I'm very much hoping for.

Hello group!

Is the community Wiki part of this new theme revision

I noticed this contrast between the community Wikipedia page and this new theme revision https://wiki.freebsd.org/

At the bottom of the page

{F141925374}

In D53910#1248962, @rcocker87_gmail.com wrote:

Hello group!

Is the community Wiki part of this new theme revision

I noticed this contrast between the community Wikipedia page and this new theme revision https://wiki.freebsd.org/

At the bottom of the page

{F141925374}

Not this release, no.

@vladlen @andy would you gentlemen please check it out? I'd love to hear our multi-lang support doesn't have any major issues after these changes.

In D53910#1249075, @maxim wrote:

@vladlen @andy would you gentlemen please check it out? I'd love to hear our multi-lang support doesn't have any major issues after these changes.

It's the same as it was - the exact lang files have been copied over, and @vladlen has been brilliant at keeping up with the changes. There are more improvements to come, which will be implemented post go-live (and they're improvements on what we had before).

You can see a staging version at https://freebsd.fortasse.cloud - please do take a look.

We would like to get this live before the end of the month, then once it is, continuously improve on things as more and more users experience it. The intention is this is *not* a 'done' site like the original, we intend to keep it alive and improving :)

Many thanks for your time folks!

Thank you for your great work! I always wanted to investigate but it's good to hear that there has been ongoing effort on this.

Just based on the look (not looking at the source code) so I can be in POV of newcomers to our website, there are a few things I would like to point out.

1. In dark mode, the background is... too dark. Can we have the colour for the dark mode background of the documentation website?
2. The header is thick. It's because in the freebsd logo on top-left, the beastie logo is too huge compared to "FreeBSD". I don't know if this is a image protected by the foundation, but we can always ask if we're allowed to modify it.
3. On the front page, the FreeBSD logo is too huge. I would make it similar size to the font of "A Powerful, Open Source Operating System". Again, the beastie logo is too huge compared to "FreeBSD"
4. The latest news to press column boxes are too crowded (font is too huge) on my laptop (responsive css issue). It would be better if they were 2 rows where the first row has 3 columns and the second row has 2 columns.
5. Same for six sections under "Why FreeBSD?". Laptops need more space (padding, margin, etc).
6. On /releases, the image on top stands out too much on non-light mode. I think removing it would be better.
7. I'm not sure if this is a bug in hugo or in website code, but when I load /where, /release, and /releng, it loads the following look below then properly loads the theme (this happens in split second, but it's quite annoying).

Other than that, there are a few padding/margin/gap issues, but I don't know how to explain this. After this patch is merged, I can tweak css to find the best layout.

In D53910#1252043, @minsoochoo0122_proton.me wrote:

Thank you for your great work! I always wanted to investigate but it's good to hear that there has been ongoing effort on this.

Just based on the look (not looking at the source code) so I can be in POV of newcomers to our website, there are a few things I would like to point out.

1. In dark mode, the background is... too dark. Can we have the colour for the dark mode background of the documentation website?
2. The header is thick. It's because in the freebsd logo on top-left, the beastie logo is too huge compared to "FreeBSD". I don't know if this is a image protected by the foundation, but we can always ask if we're allowed to modify it.
3. On the front page, the FreeBSD logo is too huge. I would make it similar size to the font of "A Powerful, Open Source Operating System". Again, the beastie logo is too huge compared to "FreeBSD"
4. The latest news to press column boxes are too crowded (font is too huge) on my laptop (responsive css issue). It would be better if they were 2 rows where the first row has 3 columns and the second row has 2 columns.
5. Same for six sections under "Why FreeBSD?". Laptops need more space (padding, margin, etc).
6. On /releases, the image on top stands out too much on non-light mode. I think removing it would be better.
7. I'm not sure if this is a bug in hugo or in website code, but when I load /where, /release, and /releng, it loads the following look below then properly loads the theme (this happens in split second, but it's quite annoying).

Other than that, there are a few padding/margin/gap issues, but I don't know how to explain this. After this patch is merged, I can tweak css to find the best layout.

Thanks for the detailed feedback @minsoochoo0122_proton.me ! Yes, once we've pushed this live it'll be great to have community interaction to 'tune' the layout. This was, is, never intended to be a finished site. It's intended to be a _working_ site we can iterate on.

Give me a couple of days to review it