Page MenuHomeFreeBSD

Use install instead of cp to copy bootstrap tools
ClosedPublic

Authored by des on Nov 14 2025, 2:59 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 17, 10:16 PM
Unknown Object (File)
Thu, Apr 16, 1:53 PM
Unknown Object (File)
Sat, Apr 11, 11:09 AM
Unknown Object (File)
Sat, Apr 11, 6:31 AM
Unknown Object (File)
Fri, Apr 10, 9:25 PM
Unknown Object (File)
Wed, Apr 8, 10:46 PM
Unknown Object (File)
Wed, Apr 8, 5:24 AM
Unknown Object (File)
Sun, Apr 5, 8:37 PM
Subscribers

Details

Summary

We need to preserve modification times on bootstrap tools, but cp -p
also tries to preserve flags, which fails if OBJROOT is on NFS. A -N
option was added to cp for this purpose, but trying to use that would
break cross-building on hosts that don't have that option. The best
remaining option is install -p, which we already assume is present.

PR: 275030

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

des requested review of this revision.Nov 14 2025, 2:59 AM
Makefile.inc1
2814–2817

This comment really ought to be updated, we haven't used links here for some time

Makefile.inc1
2814–2817

Agreed, but it's everywhere including several variable and target names so I figured let's just fix the immediate issue first and worry about cosmetics later.

des marked an inline comment as done.Nov 14 2025, 2:37 PM
This revision is now accepted and ready to land.Nov 14 2025, 5:20 PM