Use install instead of cp to copy bootstrap tools
ClosedPublic
Actions

Authored by des on Fri, Nov 14, 2:59 AM.

Details

Reviewers

imp
emaste

Commits

rGfcca6e11694d: Use install instead of cp to copy bootstrap tools
rGc67643712dc6: Use install instead of cp to copy bootstrap tools
rGf3cf4c0af5af: Use install instead of cp to copy bootstrap tools

Summary

We need to preserve modification times on bootstrap tools, but cp -p
also tries to preserve flags, which fails if OBJROOT is on NFS. A -N
option was added to cp for this purpose, but trying to use that would
break cross-building on hosts that don't have that option. The best
remaining option is install -p, which we already assume is present.

PR: 275030

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

des created this revision.Fri, Nov 14, 2:59 AM

Herald added a subscriber: emaste. · View Herald TranscriptFri, Nov 14, 2:59 AM

des requested review of this revision.Fri, Nov 14, 2:59 AM

Harbormaster completed remote builds in B68626: Diff 166416.Fri, Nov 14, 2:59 AM

emaste added inline comments.Fri, Nov 14, 3:19 AM

Makefile.inc1
2814–2817	This comment really ought to be updated, we haven't used links here for some time

des added inline comments.Fri, Nov 14, 2:26 PM

Makefile.inc1
2814–2817	Agreed, but it's everywhere including several variable and target names so I figured let's just fix the immediate issue first and worry about cosmetics later.