Page MenuHomeFreeBSD

igb(4): Fix out-of-bounds register access on VFs
ClosedPublic

Authored by kgalazka on Oct 8 2025, 8:10 AM.
Tags
None
Referenced Files
F174495602: D52976.id163750.diff
Sat, Oct 3, 5:11 PM
F174495583: D52976.id164999.diff
Sat, Oct 3, 5:11 PM
F174493985: D52976.id164700.diff
Sat, Oct 3, 4:50 PM
Unknown Object (File)
Fri, Oct 2, 12:11 AM
Unknown Object (File)
Thu, Oct 1, 4:56 PM
Unknown Object (File)
Thu, Oct 1, 12:15 PM
Unknown Object (File)
Sun, Sep 13, 3:28 AM
Unknown Object (File)
Sun, Sep 13, 3:27 AM

Details

Summary

Virtual Functions have access to a limited number of registers,
and their bus space size is lower. Use KASSERT to detect out-of-bounds
access and eliminate them to avoid kernel panics in production
environment.

Signed-off-by: Krzysztof Galazka <krzysztof.galazka@intel.com>

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Wake-on-Lan configuration is not available for VFs.

sys/dev/e1000/if_em.c
1585

I wish these checks against !sc->vf_ifp were replaced with something like a E1000_IS_VF() macro, but is that what that check is for?

4382

Interesting...?

green light from validation point of view

This revision is now accepted and ready to land.Oct 23 2025, 10:46 AM
sys/dev/e1000/if_em.c
1585

Yeah, I was thinking about some refactoring, but I would prefer to do it as separate patch if you don't mind.

erj added inline comments.
sys/dev/e1000/if_em.c
1585

Sure.