Page MenuHomeFreeBSD

krb5: remove private headers
ClosedPublic

Authored by ivy on Jul 25 2025, 11:32 AM.
Tags
None
Referenced Files
F131617728: D51518.id.diff
Thu, Oct 9, 7:15 PM
F131606318: D51518.id.diff
Thu, Oct 9, 4:48 PM
F131606310: D51518.id159076.diff
Thu, Oct 9, 4:48 PM
F131606299: D51518.id159066.diff
Thu, Oct 9, 4:47 PM
Unknown Object (File)
Thu, Oct 9, 3:04 PM
Unknown Object (File)
Sat, Sep 20, 7:36 PM
Unknown Object (File)
Sat, Sep 20, 12:18 AM
Unknown Object (File)
Sep 5 2025, 11:21 PM
Subscribers

Details

Summary

I compared the contents of the FreeBSD-kerberos-lib-dev package with
the contents of the security/krb5 port. Based on that, remove all
the headers which are installed by base krb5 but not by the port.
These all appear to be internal headers which are not meant to be
publicly visible.

This removes some headers with unfortunate conflict-prone names like
<internal.h> and <dyn.h>.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 65706
Build 62589: arc lint + arc unit

Event Timeline

ivy requested review of this revision.Jul 25 2025, 11:32 AM

this breaks a clean build... i'll update with a fixed version shortly.

des added inline comments.
krb5/lib/kadm5clnt/Makefile
12

this is redundant

krb5/lib/kadm5srv/Makefile
12

this is redundant

krb5/lib/krad/Makefile
12

this is redundant

krb5/lib/rpc/Makefile
12

this is redundant

This revision is now accepted and ready to land.Jul 25 2025, 12:05 PM

fix the build

we need to add -I${KRB5_DIR}/lib in a few places where we aren't copying the
headers anymore.

for now i'm ignoring Makefile.inc or SUFFIXES, i'll examine all the krb5
Makefiles later and do a separate commit to fix all of these.

This revision now requires review to proceed.Jul 25 2025, 1:08 PM
This revision is now accepted and ready to land.Jul 25 2025, 1:46 PM