Page MenuHomeFreeBSD

krb5: append to LDFLAGS instead of replacing
Needs ReviewPublic

Authored by chs on Tue, Feb 17, 6:05 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 9, 6:06 PM
Unknown Object (File)
Sun, Mar 8, 5:05 AM
Unknown Object (File)
Fri, Mar 6, 1:47 PM
Unknown Object (File)
Sun, Mar 1, 3:21 AM
Unknown Object (File)
Wed, Feb 25, 5:55 AM
Unknown Object (File)
Wed, Feb 25, 2:14 AM
Unknown Object (File)
Wed, Feb 25, 12:35 AM
Unknown Object (File)
Wed, Feb 25, 12:34 AM
Subscribers

Details

Reviewers
imp
Group Reviewers
krb5
Summary

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 70735
Build 67618: arc lint + arc unit

Event Timeline

chs requested review of this revision.Tue, Feb 17, 6:05 PM

is there any way we could consolidate this in a single Makefile rather than sprinkling it all over the place?

Why is this needed? Do these libraries depend on symbols which the application is expected to define?

This patch does not change what any of these Makefiles add to LDFLAGS. What is being changed by this patch to have these Makefile add their options to any existing contents of $LDFLAGS by using "LDFLAGS += ..." rather than discarding any existing contents of $LDFLAGS by using "LDFLAGS = ..." . I have no idea why any of these Makefiles want to add anything to LDFLAGS or if there is a better way to accomplish their goal, all I want to change is to add the "+'" in between "LDFLAGS" and "=".

These Makefiles will then match what almost all other Makefiles in base do, with the only exceptions being stuff like third-party Makefiles in src/contrib that are not used, and Makefiles in places src/stand where what is being built is not a normal application or shared library.