Differential D50832
stand: Add support for `print_delay` environment variable in loader Authored by obiwac on Fri, Jun 13, 1:14 PM. Tags None Referenced Files
Details This adds support for a new print_delay environment variable, which inserts a delay (in microseconds, maybe this should be in millis instead?) when putchar encounters a newline character. This can be useful when debugging. Let me know if it's not desirable to add new error codes to libsa. Just tested in loader.efi, on my machine & in VM.
Diff Detail
Event TimelineComment Actions
For my taste it's a bit gratuitous--EINVAL should be fine. I'd think that we want to avoid adding new error strings in memory-constrained loader, but Warner has better intuition there.
Comment Actions I tend to think the new error values are a bit gratuitous as well... strtonum is approximately what we're doing and it return ERANGE or EINVAL.
| |||||||||||||||||||||||||||||||||||||||||||||||||||||