Page MenuHomeFreeBSD
Differential D50766

libclang_rt: Descend into libclang_rt to clean
ClosedPublic
Actions

Authored by markj on Jun 9 2025, 9:02 PM.
Tags
None
Referenced Files
F159957513: D50766.diff
Fri, Jun 19, 10:29 PM
F159957417: D50766.id156786.diff
Fri, Jun 19, 10:27 PM
Unknown Object (File)
Thu, May 21, 8:52 PM
Unknown Object (File)
Apr 25 2026, 6:30 AM
Unknown Object (File)
Apr 20 2026, 10:39 AM
Unknown Object (File)
Apr 16 2026, 8:14 AM
Unknown Object (File)
Apr 13 2026, 6:29 AM
Unknown Object (File)
Apr 11 2026, 12:34 PM
View All 70 Files
Subscribers
imp

Details

Reviewers
emaste
dim
brooks
Commits
rG478f97786263: libclang_rt: Descend into libclang_rt to clean
rG20c636620c69: libclang_rt: Descend into libclang_rt to clean
Summary

I discovered that during cleanworld, we don't descend into libclang_rt.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj created this revision.Jun 9 2025, 9:02 PM
Herald added a subscriber: imp. · View Herald TranscriptJun 9 2025, 9:02 PM
markj requested review of this revision.Jun 9 2025, 9:02 PM
Harbormaster completed remote builds in B64732: Diff 156737.Jun 9 2025, 9:02 PM
dim accepted this revision.Jun 10 2025, 11:21 AM

I think this makes sense, thanks. Proves how often I run cleanworld, which is almost never :)

This revision is now accepted and ready to land.Jun 10 2025, 11:21 AM
brooks accepted this revision.Jun 10 2025, 1:01 PM
emaste accepted this revision.Jun 10 2025, 1:14 PM
markj added a comment.Jun 10 2025, 1:53 PM
In D50766#1158776, @dim wrote:

I think this makes sense, thanks. Proves how often I run cleanworld, which is almost never :)

This also affects buildworld WITH_CLEAN=. I noticed because I set some build flags to avoid embedding source paths into object files when WITH_REPRODUCIBLE_BUILD is defined, but they had no effect on certain files in libclang_rt even after a clean buildworld.

Closed by commit rG20c636620c69: libclang_rt: Descend into libclang_rt to clean (authored by markj). · Explain WhyJun 10 2025, 2:13 PM
This revision was automatically updated to reflect the committed changes.
markj added a commit: rG20c636620c69: libclang_rt: Descend into libclang_rt to clean.
markj added a commit: rG478f97786263: libclang_rt: Descend into libclang_rt to clean.Jun 24 2025, 1:01 AM

Revision Contents
Changeset List

PathSize
lib/
3 lines

Diff 156786

View Options

lib/Makefile

Loading...