Page MenuHomeFreeBSD

allow vlan(4) interfaces to be created on a bridge(4)
AcceptedPublic

Authored by ivy on Sat, May 24, 12:11 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, May 26, 12:04 PM
Unknown Object (File)
Sun, May 25, 5:10 AM
Unknown Object (File)
Sat, May 24, 5:53 AM
Unknown Object (File)
Sat, May 24, 4:37 AM

Details

Reviewers
des
kevans
kp
zlei
kib
Group Reviewers
network
Summary

A vlan interface on top of a bridge will act as a layer 3 port for
bridge traffic on that vlan, sometimes called an "SVI". This allows
the host to send/receive traffic on that vlan without having to create
a separate epair(4) and vlan(4) to tag and untag the traffic.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 64399
Build 61283: arc lint + arc unit

Event Timeline

ivy requested review of this revision.Sat, May 24, 12:11 AM
sys/net/if_bridge.c
428

I think if_vlan_var.h is an appropriate spot for that. It already has vlan_trunkdev_p anyway.
if_ethersubr.c already includes it, so we're not going to be causing any include pollution.

2484

vlan = DOT1Q_VID_NULL ?

update for new vlan filtering behaviour

ivy marked 2 inline comments as done.Wed, May 28, 9:42 AM
ivy added inline comments.
sys/net/if_bridge.c
428

done in D50567.

2484

this code was unnecessarily complicated, i've simplified it and removed the default assignment.

This revision is now accepted and ready to land.Wed, May 28, 7:54 PM