Differential D50242

mbuf: Allow clusters to fill an entire jumbo page.
ClosedPublic
Actions

Authored by des on May 7 2025, 5:54 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, May 16, 3:03 AM

	Unknown Object (File)
	Fri, May 15, 12:45 AM

	Unknown Object (File)
	Fri, May 15, 12:39 AM

	Unknown Object (File)
	Tue, May 12, 11:14 AM

	Unknown Object (File)
	Tue, May 12, 8:01 AM

	Unknown Object (File)
	Sun, May 3, 6:10 PM

	Unknown Object (File)
	Sun, May 3, 9:09 AM

	Unknown Object (File)
	Mon, Apr 27, 10:52 PM

View All 75 Files

Subscribers

siderop1_netapp.com

Details

Reviewers

brooks
siderop1_netapp.com
kevans

Group Reviewers

Commits

rGcbc3efab49aa: mbuf: Allow clusters to fill an entire jumbo page.
rG271128b06986: mbuf: Allow clusters to fill an entire jumbo page.

Summary

The assumption that MCLBYTES == MJUMPAGESIZE can only happen if pages
are small is incorrect: it can also happen if MCLSHIFT is adjusted to
increase the size of clusters. Restore the ability to have clusters
fill a jumbo page, while still disallowing them from exceeding them.

MFC after: 1 week
Fixes: 840327e5ddf3, 9c3ad5ba932b
Sponsored by: NetApp, Inc.
Sponsored by: Klara, Inc.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 63997
Build 60881: arc lint + arc unit

Event Timeline

des created this revision.May 7 2025, 5:54 PM

Herald added subscribers: olce, glebius, ae, imp. · View Herald TranscriptMay 7 2025, 5:54 PM

des requested review of this revision.May 7 2025, 5:54 PM

Harbormaster completed remote builds in B63997: Diff 155067.May 7 2025, 5:54 PM

Looks good. Thanks!

This revision is now accepted and ready to land.May 7 2025, 5:59 PM

Seems reasonable. Sorry I missed that MCLBYTES is something people adjust upward.

kevans accepted this revision.May 7 2025, 6:21 PM

Closed by commit rG271128b06986: mbuf: Allow clusters to fill an entire jumbo page. (authored by des). · Explain WhyMay 7 2025, 7:01 PM

This revision was automatically updated to reflect the committed changes.

des added a commit: rG271128b06986: mbuf: Allow clusters to fill an entire jumbo page..

des added a commit: rGcbc3efab49aa: mbuf: Allow clusters to fill an entire jumbo page..May 14 2025, 9:09 AM

Revision Contents
Changeset List

Path

Size

sys/

conf/

3 lines

dev/

cxgbe/

4 lines

8 lines

kern/

4 lines

sys/

6 lines

Diff 155067

sys/conf/NOTES

Loading...

sys/dev/cxgbe/adapter.h

Loading...

sys/dev/cxgbe/t4_sge.c

Loading...

sys/kern/kern_mbuf.c

Loading...

sys/sys/mbuf.h

Loading...