: Conditionally export table of bit names
ClosedPublic
Actions

Authored by jhb on Tue, Apr 22, 3:04 AM.

Details

Reviewers

bz
imp
brooks
olce

Commits

rGac3110dc9ec0: <net/if_strings.h>: Conditionally export table of bit names

Summary

Only export the array of string names if _WANT_IFCAP_BIT_NAMES is
defined. Exporting them unconditionally can trigger unused variable
warnings if a consumer doesn't use the array.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 63623
Build 60507: arc lint + arc unit

Event Timeline

jhb created this revision.Tue, Apr 22, 3:04 AM

Herald added subscribers: glebius, melifaro, ae. · View Herald TranscriptTue, Apr 22, 3:04 AM

jhb requested review of this revision.Tue, Apr 22, 3:04 AM

Harbormaster completed remote builds in B63623: Diff 154066.Tue, Apr 22, 3:04 AM

jhb added a child revision: D49955: <net/sff8472.h>: Conditionally export table of ID names.Tue, Apr 22, 3:04 AM

jhb mentioned this in D49830: kernel/gcc: turn off -Werror=unused-variable.Tue, Apr 22, 3:05 AM

bz accepted this revision.Tue, Apr 22, 5:51 PM

This revision is now accepted and ready to land.Tue, Apr 22, 5:51 PM

brooks accepted this revision.Mon, Apr 28, 3:58 PM

olce accepted this revision.Mon, Apr 28, 4:06 PM

Closed by commit rGac3110dc9ec0: <net/if_strings.h>: Conditionally export table of bit names (authored by jhb). · Explain WhyMon, Apr 28, 5:08 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rGac3110dc9ec0: <net/if_strings.h>: Conditionally export table of bit names.

Revision Contents
Changeset List

Path

Size

sbin/

ifconfig/

ifconfig_netlink.c

2 lines

sys/

net/

if_strings.h

2 lines

Diff 154066

View Options

sbin/ifconfig/ifconfig_netlink.c