Page MenuHomeFreeBSD
Differential D48611

net80211: add VHT MCS in AMRR rate control
Needs ReviewPublic
Actions

Authored by adrian on Jan 23 2025, 2:43 AM.
Tags
Referenced Files
Unknown Object (File)
Fri, Feb 14, 4:44 PM
Unknown Object (File)
Thu, Feb 13, 5:24 PM
Unknown Object (File)
Wed, Feb 12, 11:58 PM
Unknown Object (File)
Wed, Feb 12, 7:38 PM
Unknown Object (File)
Tue, Feb 11, 2:10 PM
Unknown Object (File)
Mon, Feb 10, 6:27 PM
Unknown Object (File)
Sun, Feb 9, 9:07 PM
Unknown Object (File)
Sat, Feb 8, 11:49 AM
View All 28 Files
Subscribers
bz
glebius
imp
melifaro
thj

Details

Reviewers
thj
bz
Group Reviewers
wireless
Summary

This is a simple implementation, similar to HT, to generate
VHT MCS rates for testing.

I've verified it seems to do the right thing through
MCS 0..9 and NSS 1..2. It's not very optimal - same issues as
with 11n - but it at least now fully tests the 11ac TX path in
rtwn and the tx rate refactoring.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 62588
Build 59472: arc lint + arc unit

Event Timeline

adrian created this revision.Jan 23 2025, 2:43 AM
Herald added subscribers: glebius, melifaro, imp. · View Herald TranscriptJan 23 2025, 2:43 AM
adrian requested review of this revision.Jan 23 2025, 2:43 AM
Harbormaster completed remote builds in B61904: Diff 149742.Jan 23 2025, 2:43 AM
adrian added a parent revision: D48429: amrr: refactor amrr_node_init() into HT and legacy paths.Jan 23 2025, 2:43 AM
adrian added a child revision: D48612: net80211: add ieee80211_phy_vht_get_mcs_kbit().
adrian added a reviewer: wireless.Jan 23 2025, 3:06 AM
adrian added a project: wireless.
adrian updated this revision to Diff 149853.Jan 24 2025, 1:52 AM

rebase

Harbormaster completed remote builds in B61964: Diff 149853.Jan 24 2025, 1:52 AM
adrian updated this revision to Diff 149905.Fri, Jan 24, 3:32 PM

rebase

Harbormaster completed remote builds in B61991: Diff 149905.Fri, Jan 24, 3:32 PM
adrian updated this revision to Diff 150009.Mon, Jan 27, 12:16 AM

rebase, address changes

Harbormaster completed remote builds in B62057: Diff 150009.Mon, Jan 27, 12:16 AM
thj requested changes to this revision.Tue, Jan 28, 9:48 AM
thj added a subscriber: thj.
thj added inline comments.
sys/net80211/ieee80211_amrr.c
257–258
258–261
535–536
This revision now requires changes to proceed.Tue, Jan 28, 9:48 AM
adrian added inline comments.Tue, Jan 28, 9:27 PM
sys/net80211/ieee80211_amrr.c
258–261

OOOOOPPPPPSSSSSS

adrian updated this revision to Diff 150083.Tue, Jan 28, 9:30 PM

oops fix typo, thanks tom!

Harbormaster completed remote builds in B62085: Diff 150083.Tue, Jan 28, 9:30 PM
adrian marked 3 inline comments as done.Tue, Jan 28, 9:30 PM
adrian updated this revision to Diff 150155.Thu, Jan 30, 5:15 AM

update, add TXRATE_HT

Harbormaster completed remote builds in B62120: Diff 150155.Thu, Jan 30, 5:15 AM
adrian updated this revision to Diff 150170.Thu, Jan 30, 5:16 AM

update, add TXRATE_HT

Harbormaster completed remote builds in B62135: Diff 150170.Thu, Jan 30, 5:16 AM
adrian updated this revision to Diff 151104.Mon, Feb 17, 4:40 AM

rebase

Harbormaster completed remote builds in B62481: Diff 151104.Mon, Feb 17, 4:40 AM
bz requested changes to this revision.Sat, Feb 22, 10:41 AM
bz added a subscriber: bz.
bz added inline comments.
sys/net80211/ieee80211_amrr.c
152

This is done in the caller already now?

280

Kind-of want to amend the comment with: (whether supported or not -- ieee80211_vht_node_check_tx_valid_mcs() will catch the unsupported cases)

357

Can you fold these into two lines not four?

398

Reset counters.

559

No { } needed.

564

What is "it"?

588–589

This line kind-of wants to move below the HT block as there's no need for it before the if (is_enough(..))

589

return ()

This revision now requires changes to proceed.Sat, Feb 22, 10:41 AM
adrian updated this revision to Diff 151358.Sun, Feb 23, 12:41 AM

updates from bz@

Harbormaster completed remote builds in B62588: Diff 151358.Sun, Feb 23, 12:41 AM
adrian updated this revision to Diff 151359.Sun, Feb 23, 12:42 AM

more updates from bz@

Harbormaster completed remote builds in B62589: Diff 151359.Sun, Feb 23, 12:42 AM
adrian marked 8 inline comments as done.Sun, Feb 23, 12:43 AM

updated, thanks!

Revision Contents
Changeset List

PathSize
sys/
net80211/
4 lines
183 lines

Diff 151358

View Options

sys/net80211/ieee80211_amrr.h

Loading...
View Options

sys/net80211/ieee80211_amrr.c

Loading...