Framework: Allow setting the 'vital' flag from a port
ClosedPublic
Actions

Authored by arrowd on Jan 27 2025, 11:26 AM.

Details

Reviewers

bapt

Group Reviewers

portmgr

Commits

R11:b2f07f85ad86: Framework: Allow setting the 'vital' flag from a port

Summary

Rationale for this change is following.

In our project we have a large meta-port that represents all the 3rd-party
software that makes up our distribution. This is sort of pkgbase, but at the
higher level.

We want to make sure this metapackage and all its dependents are never removed,
hence need to set the vital flag from the port.

This feature is not intended to be used in the main branch, but may be useful
for enterprise consumers of the Ports tree. Maybe the knob should be even named
_VITAL, bikeshedding is welcome.

Test Plan

make create-manifest contains vital : true for a port containing VITAL=yes

Diff Detail

Repository

R11 FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 62065
Build 58949: arc lint + arc unit

Event Timeline

arrowd requested review of this revision.Jan 27 2025, 11:26 AM

arrowd created this revision.

Harbormaster completed remote builds in B62065: Diff 150022.Jan 27 2025, 11:26 AM

We should probably also add a comment in bsd.port.mk which clearly state this should not be used directly in the ports tree, but that is another story

This revision is now accepted and ready to land.Jan 27 2025, 12:50 PM

Closed by commit R11:b2f07f85ad86: Framework: Allow setting the 'vital' flag from a port (authored by arrowd). · Explain WhyJan 28 2025, 12:03 PM

This revision was automatically updated to reflect the committed changes.

arrowd added a commit: R11:b2f07f85ad86: Framework: Allow setting the 'vital' flag from a port.

I have the same use case and setup on my systems with meta packages. I had manually done pkg set -v1 on the packages but some recent change means I need to use this port flag now.