Page MenuHomeFreeBSD
Differential D48616

net80211: update get_sta_info() to only populate isi_txrate for legacy rates
ClosedPublic
Actions

Authored by adrian on Jan 23 2025, 2:45 AM.
Tags
Referenced Files
F171192403: D48616.id.diff
Wed, Sep 9, 9:58 AM
F171127433: D48616.id150014.diff
Tue, Sep 8, 9:15 PM
F171122290: D48616.id150175.diff
Tue, Sep 8, 8:30 PM
F171109046: D48616.diff
Tue, Sep 8, 6:23 PM
F171099571: D48616.id149747.diff
Tue, Sep 8, 5:00 PM
Unknown Object (File)
Tue, Sep 8, 9:41 AM
Unknown Object (File)
Tue, Sep 8, 9:04 AM
Unknown Object (File)
Tue, Sep 8, 7:30 AM
View All Files
Subscribers
bz
glebius
imp
melifaro

Details

Reviewers
thj
Group Reviewers
wireless
Commits
rG17e8437e8d05: net80211: update get_sta_info() to only populate isi_txrate for legacy rates
Summary

The isi_txrate field is 8 bits and only represents legacy/HT rates.
So to avoid logging a warning, only populate if it's a legacy/HT
rate.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 61996
Build 58880: arc lint + arc unit

Event Timeline

adrian created this revision.Jan 23 2025, 2:45 AM
Herald added subscribers: glebius, melifaro, imp. · View Herald TranscriptJan 23 2025, 2:45 AM
adrian requested review of this revision.Jan 23 2025, 2:45 AM
Harbormaster completed remote builds in B61909: Diff 149747.Jan 23 2025, 2:45 AM
adrian added a parent revision: D48615: net80211: migrate ieee80211_rate2media() to use ieee80211_node_txrate.Jan 23 2025, 2:45 AM
adrian added a reviewer: wireless.Jan 23 2025, 3:08 AM
adrian added a project: wireless.
adrian updated this revision to Diff 149858.Jan 24 2025, 1:53 AM

rebase

Harbormaster completed remote builds in B61969: Diff 149858.Jan 24 2025, 1:53 AM
adrian updated this revision to Diff 149910.Jan 24 2025, 3:32 PM

rebase

Harbormaster completed remote builds in B61996: Diff 149910.Jan 24 2025, 3:32 PM
adrian updated this revision to Diff 150014.Jan 27 2025, 12:16 AM

rebase, address changes

Harbormaster completed remote builds in B62062: Diff 150014.Jan 27 2025, 12:16 AM
thj accepted this revision.Jan 28 2025, 10:10 AM
This revision is now accepted and ready to land.Jan 28 2025, 10:10 AM
adrian updated this revision to Diff 150175.Jan 30 2025, 5:16 AM

update, add TXRATE_HT

This revision now requires review to proceed.Jan 30 2025, 5:16 AM
Harbormaster completed remote builds in B62140: Diff 150175.Jan 30 2025, 5:16 AM
adrian added a child revision: D48996: wlanwds: use a local copy of the ifaddr sockaddr, avoid cast.Feb 13 2025, 6:34 PM
bz added a subscriber: bz.Feb 22 2025, 11:24 AM
bz added inline comments.
sys/net80211/ieee80211_ioctl.c
413

XXX TODO mark these things in a way that people can notice that they are TODOs and not descriptive text. Helps :)

adrian updated this revision to Diff 151492.Feb 26 2025, 5:15 AM

update from bz

Harbormaster completed remote builds in B62632: Diff 151492.Feb 26 2025, 5:15 AM
adrian marked an inline comment as done.Feb 26 2025, 5:15 AM

updated, thanks!

This revision was not accepted when it landed; it landed in state Needs Review.Feb 26 2025, 7:32 PM
Closed by commit rG17e8437e8d05: net80211: update get_sta_info() to only populate isi_txrate for legacy rates (authored by adrian). · Explain Why
This revision was automatically updated to reflect the committed changes.
adrian added a commit: rG17e8437e8d05: net80211: update get_sta_info() to only populate isi_txrate for legacy rates.
adrian removed a child revision: D48996: wlanwds: use a local copy of the ifaddr sockaddr, avoid cast.Feb 27 2025, 2:27 AM

Revision Contents
Changeset List

PathSize
sys/
net80211/
10 lines

Diff 149910

View Options

sys/net80211/ieee80211_ioctl.c

Loading...