, sort
ClosedPublic
Actions

Authored by olce on Dec 3 2024, 4:57 PM.

Details

Reviewers

emaste
bapt

Commits

rGafeec66ce393: syscallsubr.h: Header inclusions: Explicit <sys/param.h>, sort
rGeed08497de05: syscallsubr.h: Header inclusions: Explicit <sys/param.h>, sort
rG8cdb0458e12e: syscallsubr.h: Header inclusions: Explicit <sys/types.h>, sort

Summary

<sys/types.h> is currently brought in by other headers but some of its
type definition are directly used in this header, so it should appear
explicitly. It is necessary as lots of prototypes in there use types it
defines (<sys/_types.h> wouldn't be enough).

Sort header inclusions as per style(9).

No functional change (intended).

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 60930
Build 57814: arc lint + arc unit

Event Timeline

olce created this revision.Dec 3 2024, 4:57 PM

Herald added a subscriber: imp. · View Herald TranscriptDec 3 2024, 4:57 PM

olce requested review of this revision.Dec 3 2024, 4:57 PM

Harbormaster completed remote builds in B60930: Diff 147404.Dec 3 2024, 4:57 PM

So if sys/_types.h won't suffice, I'd call out why in the commit message (this file makes no pretense of being namespace clean I think would be the reason.)

In D47881#1091936, @imp wrote:

So if sys/_types.h won't suffice, I'd call out why in the commit message (this file makes no pretense of being namespace clean I think would be the reason.)

Commit message amended.

olce added a child revision: D47618: New setcred() system call and associated MAC hooks.Dec 9 2024, 9:50 AM

This revision was not accepted when it landed; it landed in state Needs Review.Dec 16 2024, 2:46 PM

Closed by commit rG8cdb0458e12e: syscallsubr.h: Header inclusions: Explicit <sys/types.h>, sort (authored by olce). · Explain Why

This revision was automatically updated to reflect the committed changes.

olce added a commit: rG8cdb0458e12e: syscallsubr.h: Header inclusions: Explicit <sys/types.h>, sort.

olce added a commit: rGeed08497de05: syscallsubr.h: Header inclusions: Explicit <sys/param.h>, sort.Jan 16 2025, 6:09 PM

olce added a commit: rGafeec66ce393: syscallsubr.h: Header inclusions: Explicit <sys/param.h>, sort.Jan 17 2025, 12:28 PM