Page MenuHomeFreeBSD
Differential D45318

physmem: zero entire array
ClosedPublic
Actions

Authored by mhorne on May 23 2024, 7:14 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 19, 12:32 PM
Unknown Object (File)
Wed, Apr 16, 11:37 PM
Unknown Object (File)
Tue, Apr 15, 1:00 AM
Unknown Object (File)
Tue, Apr 8, 10:30 PM
Unknown Object (File)
Sat, Apr 5, 9:49 AM
Unknown Object (File)
Sat, Apr 5, 12:09 AM
Unknown Object (File)
Sun, Mar 30, 1:29 PM
Unknown Object (File)
Mar 2 2025, 4:04 PM
View All Files
Subscribers
emaste
imp
olce

Details

Reviewers
kevans
andrew
manu
Commits
rG191e6a604938: physmem: zero entire array
Summary

As a convenience to callers. An empty/zero-valued range indicates the
end of the physmap entries.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 58053
Build 54941: arc lint + arc unit

Event Timeline

mhorne created this revision.May 23 2024, 7:14 PM
Herald added subscribers: olce, imp. · View Herald TranscriptMay 23 2024, 7:14 PM
mhorne requested review of this revision.May 23 2024, 7:14 PM
Harbormaster completed remote builds in B57871: Diff 139000.May 23 2024, 7:14 PM
andrew added a comment.Jun 4 2024, 9:24 AM

You can remove the bzero calls from ram_attach and the arm64 pmap_bootstrap_san1.

mhorne updated this revision to Diff 139444.Jun 4 2024, 5:14 PM

Remove now-redundant calls to bzero().

Herald added a reviewer: manu. · View Herald TranscriptJun 4 2024, 5:14 PM
Herald added a subscriber: emaste. · View Herald Transcript
Harbormaster completed remote builds in B58053: Diff 139444.Jun 4 2024, 5:14 PM
andrew accepted this revision.Jun 4 2024, 5:33 PM
This revision is now accepted and ready to land.Jun 4 2024, 5:33 PM
Closed by commit rG191e6a604938: physmem: zero entire array (authored by mhorne). · Explain WhyJun 4 2024, 11:20 PM
This revision was automatically updated to reflect the committed changes.
mhorne added a commit: rG191e6a604938: physmem: zero entire array.

Revision Contents
Changeset List

PathSize
sys/
arm64/
arm64/
1 line
kern/
3 lines

Diff 139444

View Options

sys/arm64/arm64/pmap.c

.\" $FreeBSD$ .\" $FreeBSD$
Set to not build and install the enhanced Install the traditional FreeBSD
.Xr bc 1 .Xr bc 1
jhbUnsubmitted
Not Done
Inline Actions

I would maybe avoid making other changes for this commit than just the "Set to" part. Losing the Xr sections for bc and dc seems rather odd.

Granted, I would rewrite this description to be something like "Use the traditional FreeBSD versions of bc(1) and dc(1) rather than the <foo> versions." where <foo> is more descriptive than just "enhanced".

jhb: I would maybe avoid making other changes for this commit than just the "Set to" part. Losing…
emasteAuthorUnsubmitted
Done
Inline Actions

Huh, I think this must have been an accident during a rebase, I did not intend to drop these. When I first did this it was a bit of sed with manual review/touch-ups. In can incorporate feedback before this gets committed and/or we can make further improvements like this one after commit.

I am also not sure what <foo> would be off hand.

emaste: Huh, I think this must have been an accident during a rebase, I did not intend to drop these.
and and
.Xr dc 1 .Xr dc 1
programs instead of the traditional FreeBSD versions. programs instead of the enahnced versions.
emasteAuthorUnsubmitted
Done
Inline Actions

and of course I have a typo here. corrected locally.

emaste: and of course I have a typo here. corrected locally.
View Options

sys/kern/subr_physmem.c

.\" $FreeBSD$ .\" $FreeBSD$
Set to not build and install the enhanced Install the traditional FreeBSD
.Xr bc 1 .Xr bc 1
jhbUnsubmitted
Not Done
Inline Actions

I would maybe avoid making other changes for this commit than just the "Set to" part. Losing the Xr sections for bc and dc seems rather odd.

Granted, I would rewrite this description to be something like "Use the traditional FreeBSD versions of bc(1) and dc(1) rather than the <foo> versions." where <foo> is more descriptive than just "enhanced".

jhb: I would maybe avoid making other changes for this commit than just the "Set to" part. Losing…
emasteAuthorUnsubmitted
Done
Inline Actions

Huh, I think this must have been an accident during a rebase, I did not intend to drop these. When I first did this it was a bit of sed with manual review/touch-ups. In can incorporate feedback before this gets committed and/or we can make further improvements like this one after commit.

I am also not sure what <foo> would be off hand.

emaste: Huh, I think this must have been an accident during a rebase, I did not intend to drop these.
and and
.Xr dc 1 .Xr dc 1
programs instead of the traditional FreeBSD versions. programs instead of the enahnced versions.
emasteAuthorUnsubmitted
Done
Inline Actions

and of course I have a typo here. corrected locally.

emaste: and of course I have a typo here. corrected locally.