Page MenuHomeFreeBSD

arm64: Add a CPU reset hook instead of expecting PSCI
ClosedPublic

Authored by stevek on Mar 27 2024, 9:18 PM.
Tags
None
Referenced Files
F161640476: D44535.diff
Sun, Jul 5, 12:38 PM
Unknown Object (File)
Fri, Jul 3, 1:09 PM
Unknown Object (File)
Fri, Jul 3, 4:20 AM
Unknown Object (File)
Thu, Jul 2, 6:31 PM
Unknown Object (File)
Thu, Jul 2, 1:36 AM
Unknown Object (File)
Wed, Jul 1, 9:55 AM
Unknown Object (File)
Wed, Jul 1, 7:31 AM
Unknown Object (File)
Sat, Jun 27, 2:35 PM
Subscribers

Details

Summary

Some SoCs do not include a PSCI for power management and defer it to
something else instead. Add a CPU reset hook to account for this, and
use it in the psci driver.

Obtained from: Juniper Networks, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 56810
Build 53698: arc lint + arc unit

Event Timeline

Is there a reason to not have cpu_reset_hook = psci_reset by default so we can remove the NULL check?

Is there a reason to not have cpu_reset_hook = psci_reset by default so we can remove the NULL check?

Given that psci.c is "standard" on arm64 and it will not do anything until/unless it probes/attaches (and thus psci_softc is non-NULL), yes, I believe it could just default to psci_reset (maybe with a comment stating the reasons why?)

Updated based on review comments

This revision is now accepted and ready to land.Apr 4 2024, 11:10 AM