Page MenuHomeFreeBSD
Differential D44380

syscalls.master: don't use struct siginfo
ClosedPublic
Actions

Authored by brooks on Mar 15 2024, 10:45 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 30, 11:36 AM
Unknown Object (File)
Sun, Nov 30, 7:14 AM
Unknown Object (File)
Sat, Nov 29, 4:28 PM
Unknown Object (File)
Nov 27 2025, 10:12 PM
Unknown Object (File)
Nov 27 2025, 2:37 PM
Unknown Object (File)
Nov 26 2025, 1:42 PM
Unknown Object (File)
Nov 26 2025, 11:58 AM
Unknown Object (File)
Nov 26 2025, 10:48 AM
View All 95 Files
Subscribers
emaste
imp
jhibbits
olce

Details

Reviewers
kib
andrew
manu
Commits
rGcab73e530564: syscalls.master: struct siginfo -> struct __siginfo
rGd060b420e0f6: freebsd32: struct siginfo32 -> struct __siginfo32
Summary

It doesn't exist. Instead, use struct __siginfo which does.

Rename struct siginfo32 to struct __siginfo32 to keep the ABI
transformations in makesyscalls.lua working.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 56634
Build 53522: arc lint + arc unit

Event Timeline

brooks created this revision.Mar 15 2024, 10:45 PM
Herald added a reviewer: andrew. · View Herald TranscriptMar 15 2024, 10:45 PM
Herald added a reviewer: andrew. · View Herald Transcript
Herald added a reviewer: manu. · View Herald Transcript
Herald added subscribers: olce, jhibbits, emaste, imp. · View Herald Transcript
brooks requested review of this revision.Mar 15 2024, 10:45 PM
Harbormaster completed remote builds in B56634: Diff 135804.Mar 15 2024, 10:45 PM
brooks added a parent revision: D44379: syscalls.master: align with sigfastblock declaration.Mar 15 2024, 10:45 PM
brooks added a child revision: D44387: libsys: add a libsys.h.Mar 15 2024, 10:48 PM
kib accepted this revision.Mar 16 2024, 1:35 AM

I would prefer this one split into two: siginfo32 first, the siginfo second, even if the inter-commit base cannot be built.

This revision is now accepted and ready to land.Mar 16 2024, 1:35 AM
brooks added a comment.Mar 18 2024, 9:44 PM
In D44380#1012169, @kib wrote:

I would prefer this one split into two: siginfo32 first, the siginfo second, even if the inter-commit base cannot be built.

I've made this split locally.

Closed by commit rGd060b420e0f6: freebsd32: struct siginfo32 -> struct __siginfo32 (authored by brooks). · Explain WhyMar 19 2024, 11:16 PM
This revision was automatically updated to reflect the committed changes.
brooks added a commit: rGd060b420e0f6: freebsd32: struct siginfo32 -> struct __siginfo32.
brooks added a commit: rGcab73e530564: syscalls.master: struct siginfo -> struct __siginfo.

Revision Contents
Changeset List

PathSize
sys/
amd64/
ia32/
4 lines
arm64/
arm64/
5 lines
include/
2 lines
compat/
freebsd32/
14 lines
2 lines
ia32/
4 lines
2 lines
kern/
6 lines
powerpc/
powerpc/
6 lines
sys/
2 lines
2 lines

Diff 135804

View Options

sys/amd64/ia32/ia32_signal.c

Loading...
View Options

sys/arm64/arm64/freebsd32_machdep.c

Loading...
View Options

sys/arm64/include/frame.h

Loading...
View Options

sys/compat/freebsd32/freebsd32_misc.c

Loading...
View Options

sys/compat/freebsd32/freebsd32_signal.h

Loading...
View Options

sys/compat/ia32/ia32_signal.h

Loading...
View Options

sys/compat/ia32/ia32_sysvec.c

Loading...
View Options

sys/kern/syscalls.master

Loading...
View Options

sys/powerpc/powerpc/exec_machdep.c

Loading...
View Options

sys/sys/ptrace.h

Loading...
View Options

sys/sys/signal.h

Loading...