Make WITHOUT_UNDEFINED_VERSION the default
ClosedPublic
Actions

Authored by brooks on Mar 5 2024, 1:07 AM.

Details

Reviewers

dim
arichardson
emaste
kib

Commits

rG6edb14c006f6: Make WITHOUT_UNDEFINED_VERSION the default
rG4510f2ca9170: Make WITHOUT_UNDEFINED_VERSION the default

Summary

Link with --no-undefined-version by default. Will detect and prevent
the accidental removal of symbols from versioned libraries.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 56437
Build 53325: arc lint + arc unit

Event Timeline

brooks created this revision.Mar 5 2024, 1:07 AM

Herald added subscribers: emaste, imp, bdrewery. · View Herald TranscriptMar 5 2024, 1:07 AM

brooks requested review of this revision.Mar 5 2024, 1:07 AM

Harbormaster completed remote builds in B56437: Diff 135383.Mar 5 2024, 1:07 AM

This is successful everywhere (i.e. architectures, discounting conflicts with other options that Michael Dexter's option survey will find)?

This isn't ready to land, but adding it to give me somewhere to hang all the otherwise unrelated reviews I'll post over the next day or so (I've got amd64 and i386 working so far).

brooks added child revisions: D44188: libc: don't try to export __sF, D44187: libc: don't try to export _nsdbtdump, D44186: libc: don't try to export mexitcount, D44185: libc: don't try to export mpool_stat, D44184: libc: only export hesiod symbols when enabled, D44183: libc/iconv: don't export nonexistant symbols, D44182: locale: don't expose nonexistant __collate_load_error, D44189: libc: actually build bsearch_b.Mar 5 2024, 1:11 AM

brooks removed child revisions: D44189: libc: actually build bsearch_b, D44182: locale: don't expose nonexistant __collate_load_error, D44183: libc/iconv: don't export nonexistant symbols, D44184: libc: only export hesiod symbols when enabled, D44185: libc: don't try to export mpool_stat, D44186: libc: don't try to export mexitcount, D44187: libc: don't try to export _nsdbtdump, D44188: libc: don't try to export __sF.

brooks added parent revisions: D44189: libc: actually build bsearch_b, D44182: locale: don't expose nonexistant __collate_load_error, D44188: libc: don't try to export __sF, D44187: libc: don't try to export _nsdbtdump, D44186: libc: don't try to export mexitcount, D44185: libc: don't try to export mpool_stat, D44184: libc: only export hesiod symbols when enabled, D44183: libc/iconv: don't export nonexistant symbols.

brooks added a parent revision: D44241: lib{c,sys}: return wrapped syscall APIs to libc.Mar 5 2024, 9:52 PM

brooks added a parent revision: D44243: libc/quad: narrow list of symbols exposed on i386.Mar 5 2024, 10:10 PM

brooks added a parent revision: D44244: libthr: restore _pthread_cond_timedwait.

brooks added a parent revision: D44246: heimdal: don't try to expose nonexistant symbols.Mar 5 2024, 10:15 PM

brooks added parent revisions: D44249: openssl: don't export nonexistant symbols, D44248: librpcsec_gss: don't export non-existant symbols, D44247: liblzma: don't export lzma_lz_decoder_uncompressed.Mar 5 2024, 10:22 PM

editor_callfortesting.org added a subscriber: editor_callfortesting.org.Mar 6 2024, 8:32 AM

brooks mentioned this in D44271: bsd.lib.mk: add targets to detect symbol changes.Mar 7 2024, 7:59 PM

brooks added a parent revision: D44324: libgcc_s: exclude symbols not present on some arches.Mar 12 2024, 9:12 PM

brooks added a parent revision: D44325: libcxxrt: don't export nonexistant symbols.Mar 12 2024, 9:15 PM

brooks added parent revisions: D44330: libsys/arm: make vfork less of an outlier, D44327: libc/softfloat: we don't export _fp[gs]et* symbols.Mar 12 2024, 9:27 PM

brooks added a parent revision: D44331: msun/riscv: limit exposure of fegetexcept.Mar 12 2024, 9:31 PM

brooks added parent revisions: D44879: libc/quad: further narrow list of i386 symbols, D44877: libgcc_s: restore __*_frame_info symbols post llvm18.Apr 19 2024, 9:31 PM

zlei added a subscriber: zlei.Apr 21 2024, 1:40 AM

brooks added a parent revision: D45052: libgcc_s: __extendxftf2 and __trunctfxf2 are amd64-only.May 1 2024, 10:02 PM

Rebase, bump doc date

Harbormaster completed remote builds in B57522: Diff 137988.May 1 2024, 10:11 PM

With D45052 committed, this passes a make CROSS_TOOLCHAIN=llvm18 -DWITHOUT_TOOLCHAIN -DMAKE_JUST_WORLDS -j40 tinderbox run. I'll kick off a full run over night in case there are issues in the toolchain bits, but I think this is ready to land. We have had several regressions since I first posted this review so getting this in is clearly valuable (admittedly, a number of which were my fault in merging patches I failed to notice had gotten out of date.)

kib accepted this revision.May 1 2024, 10:33 PM

This revision is now accepted and ready to land.May 1 2024, 10:33 PM

arichardson accepted this revision.May 2 2024, 6:30 AM

Great!

emaste accepted this revision.May 2 2024, 12:24 PM

Closed by commit rG4510f2ca9170: Make WITHOUT_UNDEFINED_VERSION the default (authored by brooks). · Explain WhyMay 2 2024, 5:15 PM

This revision was automatically updated to reflect the committed changes.

brooks added a commit: rG4510f2ca9170: Make WITHOUT_UNDEFINED_VERSION the default.

brooks added a reverting change: rGb25ceb97eddc: Revert "Make WITHOUT_UNDEFINED_VERSION the default".May 2 2024, 9:56 PM

brooks added a commit: rG6edb14c006f6: Make WITHOUT_UNDEFINED_VERSION the default.May 20 2024, 2:50 PM