Page MenuHomeFreeBSD

libc/iconv: don't export nonexistant symbols
ClosedPublic

Authored by brooks on Mar 1 2024, 11:55 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 4, 2:56 AM
Unknown Object (File)
Tue, Dec 3, 2:19 PM
Unknown Object (File)
Tue, Dec 3, 3:54 AM
Unknown Object (File)
Sun, Nov 24, 7:38 AM
Unknown Object (File)
Thu, Nov 14, 5:10 PM
Unknown Object (File)
Nov 14 2024, 6:43 AM
Unknown Object (File)
Nov 9 2024, 6:11 PM
Unknown Object (File)
Nov 9 2024, 6:10 PM
Subscribers

Details

Summary

It's unclear to me that any of these symbols ever existed. The ones
I've spot checked are only mentioned in the initial Citrus iconv import
(commit ad30f8e79bd1) and this code hasn't changed much over time.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

lib/libc/iconv/Symbol.map
40

At least this one...

62

... and this set, or so, should be used by various lib/libiconv_modules through a lot of macro shenanigans ("indirection")... do you still end up with a functional libiconv?

ah, I see; some of these were inlined in a header, some of them left un-exported in the first place... someone seemingly applied a relatively large hammer.

This revision is now accepted and ready to land.Mar 7 2024, 2:39 AM
This revision was automatically updated to reflect the committed changes.