Differential D44330

libsys/arm: make vfork less of an outlier
ClosedPublic
Actions

Authored by brooks on Mar 12 2024, 9:25 PM.

Details

Reviewers

andrew

Group Reviewers

ARM

Commits

rG80ffc7398b83: libsys/arm: make vfork less of an outlier

Summary

Following the pattern of other architectures, make __sys_vfork the main
symbol and _vfork and vfork weak aliases. This avoids the need to
special case vfork in the generated list of symbols.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

brooks created this revision.Mar 12 2024, 9:25 PM

Herald added a reviewer: andrew. · View Herald TranscriptMar 12 2024, 9:25 PM

Herald added a subscriber: imp. · View Herald Transcript

brooks requested review of this revision.Mar 12 2024, 9:25 PM

brooks added a parent revision: D44329: libc/arm: export __signalcontext not _signalcontext.

Harbormaster completed remote builds in B56565: Diff 135671.Mar 12 2024, 9:25 PM

I can verify that this results in the right change to the symbol list, but I'm not in a position to test it easily.

brooks added a child revision: D44216: Make WITHOUT_UNDEFINED_VERSION the default.Mar 12 2024, 9:27 PM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 22 2024, 8:30 PM

Closed by commit rG80ffc7398b83: libsys/arm: make vfork less of an outlier (authored by brooks). · Explain Why

This revision was automatically updated to reflect the committed changes.

brooks added a commit: rG80ffc7398b83: libsys/arm: make vfork less of an outlier.

Revision Contents
Changeset List

Path

Size

lib/

libsys/

arm/

vfork.S

8 lines

Diff 137525

View Options

libsys/arm: make vfork less of an outlierClosedPublicActions